Skip to content

Conversation

beat-buesser
Copy link
Collaborator

Signed-off-by: Beat Buesser [email protected]

Description

This pull request fixes batch-norm layers in PyTorchYolo._get_losses.

Fixes #1859

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@beat-buesser beat-buesser self-assigned this Sep 27, 2022
@beat-buesser beat-buesser added bug Something isn't working improvement Improve implementation labels Sep 27, 2022
@beat-buesser beat-buesser added this to the ART 1.12.1 milestone Sep 27, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.87%. Comparing base (89bf92f) to head (c6df4a1).

❌ Your project status has failed because the head coverage (85.87%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           dev_1.12.1    #1860   +/-   ##
===========================================
  Coverage       85.87%   85.87%           
===========================================
  Files             248      248           
  Lines           23310    23312    +2     
  Branches         4212     4212           
===========================================
+ Hits            20017    20019    +2     
+ Misses           2230     2229    -1     
- Partials         1063     1064    +1     
Files with missing lines Coverage Δ
art/estimators/object_detection/pytorch_yolo.py 79.28% <100.00%> (+0.24%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@beat-buesser beat-buesser merged commit 0235218 into dev_1.12.1 Sep 28, 2022
@beat-buesser beat-buesser deleted the development_issue_1859 branch September 28, 2022 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working improvement Improve implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyTorchYolo estimator affects model parameters during loss/gradient calculation
2 participants