Require users to write readme in English #1025
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidperezgar
requested review from
ernilambar,
frantorres and
chriscct7
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ernilambar
reviewed
Aug 6, 2025
| if ( ! $check_language ) { | ||
| $this->add_result_error_for_file( | ||
| $result, | ||
| __( 'The README description contains unofficial language. It must be written in standard English.', 'plugin-check' ), |
There was a problem hiding this comment.
"README" should be simply "readme" I believe.
ernilambar
reviewed
Aug 6, 2025
| @@ -370,8 +370,8 @@ public function test_run_with_errors_multiple_parser_warnings() { | |||
| $this->assertNotEmpty( $warnings ); | |||
| $this->assertArrayHasKey( 'readme.txt', $warnings ); | |||
| $this->assertSame( 7, $check_result->get_warning_count() ); | |||
| $this->assertEmpty( $errors ); | |||
| $this->assertSame( 0, $check_result->get_error_count() ); | |||
| $this->assertNotEmpty( $errors ); | |||
There was a problem hiding this comment.
We should improve our test and make sure any addition of new check does not break the existing checks.
|
Suggestions:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1009
My approach is to use the Language Detector library. It returns a list of languages that best match the content. I use the highest-scoring language; if it's not English, it gives an error.
Maybe we can set a lower severity level until we've tested it for a while.