Skip to content

Conversation

adamziel
Copy link
Collaborator

@adamziel adamziel commented Aug 7, 2025

Motivation for the change, related issues

WIP, no .wasm binaries are shipped with this PR yet

Implementation details

Testing Instructions (or ideally a Blueprint)

@adamziel adamziel requested a review from a team as a code owner August 7, 2025 12:15
@adamziel adamziel marked this pull request as draft August 7, 2025 12:16
@adamziel
Copy link
Collaborator Author

@zaerl it seems like we can't ship OPCache as a static extension starting with PHP 8.5:

https://php.watch/rfcs/make_opcache_required

The current Dockerfile either results in this error when OPCache is enabled:

141.2 wasm-ld: error: duplicate symbol: opcache_module_entry
141.2 >>> defined in ext/opcache/opcache_module.o
141.2 >>> defined in ext/opcache/zend_accelerator_module.o

Or in this one when it's disabled:

114.9 /root/php-src/main/main.c:54:10: fatal error: 'ext/opcache/ZendAccelerator.h' file not found
114.9    54 | #include "ext/opcache/ZendAccelerator.h"
114.9       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
114.9 1 error generated.
114.9 make: *** [Makefile:2494: main/main.lo] Error 1
114.9 emmake: error: 'make -j1' failed (returned 2)
------

It seems like for 8.5 we just need to accept it's a baked in default extension

@adamziel
Copy link
Collaborator Author

yay! there's some cleanup work to do but we're mostly there

CleanShot 2025-09-15 at 13 21 25@2x

@zaerl
Copy link
Collaborator

zaerl commented Sep 15, 2025

It seems like for 8.5 we just need to accept it's a baked in default extension

NP with this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants