Skip to content

Conversation

fifield
Copy link
Collaborator

@fifield fifield commented Feb 6, 2025

llvm/llvm-project#123181 replaces nocapture with capture(none), which causes a problem for chess, giving errors like:

input.llchesshack.ll:74:52: error: expected ')' at end of argument list
declare <8 x float> @llvm.masked.load.v8f32.p0(ptr captures(none), i32 immarg, <8 x i1>, <8 x float>) #1
                                                   ^

For example https://github.com/Xilinx/mlir-aie/actions/runs/13077904662/job/36494451051

llvm/llvm-project#123181 replaces `nocapture` with `capture(none)`, which causes a problem for chess. For example https://github.com/Xilinx/mlir-aie/actions/runs/13077904662/job/36494451051
@fifield fifield changed the title Update downgrade_ir_for_chess for after llvm update Update downgrade_ir_for_chess after llvm update Feb 6, 2025
@keryell
Copy link
Contributor

keryell commented Feb 6, 2025

Does this depend on the Vitis version by the way? Do we assume that MLIR AIE will work only for a specific version of Vitis? 🤔

@fifield
Copy link
Collaborator Author

fifield commented Feb 6, 2025

Does this depend on the Vitis version by the way? Do we assume that MLIR AIE will work only for a specific version of Vitis? 🤔

Yes this is a good point. For new enough versions of chess downgrade_ir_for_chess does not need to be called. I don't know which, if any, versions of Vitis contain such versions of chess.

@fifield fifield added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 8b908be Feb 6, 2025
53 checks passed
@fifield fifield deleted the nocapture branch February 6, 2025 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants