Skip to content

Conversation

gotmax23
Copy link
Contributor

toml has been unmaintained for years and was superseded by tomli on PyPI which was eventually added to the stdlib as tomllib in Python 3.11.

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

toml has been unmaintained for years and was superseded by tomli on PyPI
which was eventually added to the stdlib as tomllib in Python 3.11.

Signed-off-by: Maxwell G <[email protected]>
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gotmax23 Thanks++ for bringing this up and adding a PR.

Everything looks good to me, just one update required:

@gotmax23
Copy link
Contributor Author

Also update the requirements file similarly: https://github.com/aboutcode-org/scancode-toolkit/blob/develop/requirements.txt#L72, this is used for release archives and local development installations.

Is there a command to update them? Usually, they'd be be generated by pip-compile or in some other standardized way.

@xsuchy
Copy link
Contributor

xsuchy commented Aug 21, 2025

I will link here the Fedora Change page that contains more info about deprecation of toml and availability of tomli in older systems https://fedoraproject.org/wiki/Changes/DeprecatePythonToml

Copy link
Contributor

@xsuchy xsuchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants