Skip to content

Conversation

gotmax23
Copy link
Contributor

@gotmax23 gotmax23 commented Aug 29, 2025

This is needed for Python 3.14 compatibility.

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Updated documentation pages (if applicable)
  • Updated CHANGELOG.rst (if applicable)

This is needed for Python 3.14 compatibility.

Signed-off-by: Maxwell G <[email protected]>
Copy link
Member

@pombredanne pombredanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Is the logic really the same?

if isinstance(statement_v, (ast.Str, ast.Constant)):
value = statement_v.s
value.append(e.value)
if isinstance(statement_v, ast.Constant) and isinstance(statement_v.value, str):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic is now different, is it?
if isinstance(statement_v, (ast.Str, ast.Constant)): would kick in on either of ast.Str or ast.Constant but now it only kicks in with ast.Constant with a string value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants