fix: use Code.ensure_compiled! at compile time
#1361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While investigating the changes in this PR: elixir-lang/elixir#14451 I encountered an error about not being able to load a module at this line, implying this is called at compile time. @josevalim pointed out that `Code.ensure_loaded!/1` will have no effect at compile time, and so this was really just relying on compile order and would be non-deterministic. `Code.ensure_compiled!/1` is a superset of `Code.ensure_loaded!/1` and will work at compile time to ensure the depended on module is compiled. This would appear to solve absinthe-graphql#1351.
|
It should be noted that this error may affect people more significantly in the next version of Elixir so we may want to get this merged sooner rather than later 😄 |
josevalim
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating the changes in this PR:
elixir-lang/elixir#14451
I encountered an error about not being able to load a module at this line, implying this is called at compile time.
@josevalim pointed out that
Code.ensure_loaded!/1will have no effect at compile time, and so this was really just relying on compile order and would be non-deterministic.Code.ensure_compiled!/1is a superset ofCode.ensure_loaded!/1and will work at compile time to ensure the depended on module is compiled.This would appear to solve #1351.