Skip to content

Conversation

m-col
Copy link

@m-col m-col commented Mar 11, 2023

No description provided.

@m-col
Copy link
Author

m-col commented Mar 11, 2023

3 perfectly good commits with a good, conceptual and functional state at the end of each one. Squashing them just means we get bigger commits (both in terms of diff size and logic/conceptual changes) and thus more difficult to explore git history. IDK how you deal with commits on your PRs but IMO squashing is only appropriate if you have a mess of conceptually irrelevant commits that might have typo fixes, linting fixes, all that stuff. Here, squashing does nothing but reduce order. I'm basically taking the responsibility as the submitter to maintain good commit history pre-merge rather than only getting it upon merge, so it's more nuanced than "always squash", because some PRs need it, some don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant