Skip to content

feat: use request session id to generate the nonce #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: use request session id to generate the nonce #603

wants to merge 1 commit into from

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Apr 3, 2025

Resolves #591

@G-Rath G-Rath force-pushed the rails-8-stuff/change-nonce-generator branch 3 times, most recently from 862ca2d to 1ef7288 Compare June 13, 2025 03:11
@G-Rath G-Rath force-pushed the rails-8-stuff/change-nonce-generator branch from 1ef7288 to 9dcedaa Compare July 25, 2025 03:38
@G-Rath G-Rath force-pushed the rails-8-stuff/change-nonce-generator branch from 9dcedaa to e99ab73 Compare July 25, 2025 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmcarthur joshmcarthur joshmcarthur approved these changes

@eoinkelly eoinkelly Awaiting requested review from eoinkelly

@lukeify lukeify Awaiting requested review from lukeify

@halles halles Awaiting requested review from halles

@robotdana robotdana Awaiting requested review from robotdana

@JacobBriggsAckama JacobBriggsAckama Awaiting requested review from JacobBriggsAckama

@brooke-m brooke-m Awaiting requested review from brooke-m

@hopkincame hopkincame Awaiting requested review from hopkincame

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should we change how we generate our CSP nonce?
2 participants
@G-Rath @joshmcarthur