Make use of native SwiftUI's PhotosPicker and get rid of PhotoLibrary's permission bug. #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: The app asks for PhotoLibrary permissions to select users pictures and this is not required.
On the one hand, there is a bug in case the user denies access to PhotoLibrary, the picker gets displayed and after selecting the image nothing happens (video permissions issue below).
On the other hand, asking for PhotoLibrary permissions is not required at all as the app doesn't need access to user's photos. We can make use of the SwiftUI's native
PhotosPicker. This way the users will be able to select an image from their Photos without having to give access to all their photos to the app (also no permissions nor user's prompt is required).video-permissions-issue.mov
✅ [PhotosPicker implementation]:
photos-picker.mov
ps: I've tested this issue in the Fish Identifier app (I assume it happens in the other 2 app identifiers too). Let me know what you think @adamlyttleapps 👍
Cheers,
Pablo.