chore: switch hero autoblock for fragment autoblocking #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This should go against |
srikanth-nvi
pushed a commit
to srikanth-nvi/aem-nvi-xwalk
that referenced
this pull request
May 29, 2025
srikanth-nvi
pushed a commit
to srikanth-nvi/aem-nvi-xwalk
that referenced
this pull request
May 29, 2025
* refactor: update fetchPlaceholders import path and enhance multi-store support * fix: disable eslint rule for cyclic imports in configs.js * refactor: update fetchPlaceholders function for improved multi-store support and remove unused preload link * index all pages in the two-tiers structure * refactor: update helix-query.yaml to exclude drafts, enrichment, and fragments from indexing * refactor: remove tiers configuration from helix-query.yaml * refactor: simplify buildConfigURL and remove unused root path handling in configs.js * fix: ensure checkIsAuthenticated returns a boolean value * refactor: enhance buildConfigURL to accept dynamic root path and update session storage keys * refactor: simplify fetchPlaceholders to support single store fetching * refactor: update fetchPlaceholders import paths to use aem.js * Update scripts/configs.js Co-authored-by: Stephen <[email protected]> * refactor: enhance fetchPlaceholders to support multiple source fetching and caching * refactor: update fetchPlaceholders to handle empty string for overrides * refactor: update loadFragment to use getRootPath for dynamic URL construction * USF-1918: Sharepoint documents have a two-tier structure with English as the default - decorate links for EDS pages - localize links for Blocks * fix: correct logical condition for link href validation * USF-1918: Sharepoint documents have a two-tier structure with English as the default - localize links for Blocks * feat: add dynamic metadata fetching for 404 page based on URL patterns * USF-1918: Sharepoint documents have a two-tier structure with English as the default - localize links for checkout block * USF-1918: Sharepoint documents have a two-tier structure with English as the default - localize links for header block - localize links for product links * Update scripts/scripts.js Co-authored-by: Mark J. Becker <[email protected]> * USF-1918: Sharepoint documents have a two-tier structure with English as the default - if link is already localized, do nothing - remove decorateLinks from default behavior * USF-1918: Sharepoint documents have a two-tier structure with English as the default - rename localizeLink to shortened rootLink - remove rootLink from constants - localize more links within Blocks * USF-1918: Sharepoint documents have a two-tier structure with English as the default - do not localize modal css path * Localize more links Co-authored-by: Chuting (Christina) Yan <[email protected]> * [USF-1182]-StoreSwitcher (adobe#316) * LYNX-734: Correct GraphQL type name CustomerGroup -> customerGroup (adobe#312) * USF-1990 Update home page design with relevant content and images (adobe#310) * LYNX-738: Add Catalog Price Rules Support for Targeted Blocks (adobe#305) * New Checkout version v1.2.0 (adobe#313) * LYNX-755: Error when requesting segments for non-default store (adobe#314) * updated footer with storeview switcher, styling * clean up * css lint * fixed kebab case issue * fixed classname issue * Update cart to 1.0.3 (adobe#315) * Update cart to beta * Update cart with minor version * origin links issue * clean up after review: gathering store selection name, reverted fragment functions * bugfix: ordering of stores * track product view mutation (adobe#317) * LYNX-759: Separate requests for customer group and segment (adobe#318) * Fix import in PDP metadata generator (adobe#320) * LYNX-722: Style navigation menu in boilerplate * Fixed cart headers for personalisation request (adobe#325) * update packages to 0.41.0 (adobe#327) * added cypress testing for storeSwitcher * clean up * updated to show parent LI name (Currency) updated cypress tests * revert back * update tests * updated close button in footer storeswticher modal --------- Co-authored-by: Sergii Ivashchenko <[email protected]> Co-authored-by: OscarMerino <[email protected]> Co-authored-by: Rafal Janicki <[email protected]> Co-authored-by: Mike <[email protected]> Co-authored-by: Chuting (Christina) Yan <[email protected]> Co-authored-by: eliseacornejo <[email protected]> Co-authored-by: Mark J. Becker <[email protected]> Co-authored-by: Sergio Vera <[email protected]> Co-authored-by: Anthoula Wojczak <[email protected]> * USF-1182-StoreSwitcher-Follow-Up (adobe#342) * updated footer with storeview switcher, styling * clean up * css lint * fixed kebab case issue * fixed classname issue * origin links issue * clean up after review: gathering store selection name, reverted fragment functions * bugfix: ordering of stores * added cypress testing for storeSwitcher * clean up * updated to show parent LI name (Currency) updated cypress tests * revert back * update tests * updated close button in footer storeswticher modal * added fallbacks if store-switcher fragment is not available, pulled metaData to check * updated cypress test * updated error messaging * Add rootLink to search result (adobe#349) * remove unecessary decorateLinks --------- Co-authored-by: Stephen <[email protected]> Co-authored-by: Anthoula Wojczak <[email protected]> Co-authored-by: Mark J. Becker <[email protected]> Co-authored-by: Anthoula Wojczak <[email protected]> Co-authored-by: Chuting (Christina) Yan <[email protected]> Co-authored-by: Eric Oeur <[email protected]> Co-authored-by: Sergii Ivashchenko <[email protected]> Co-authored-by: OscarMerino <[email protected]> Co-authored-by: Rafal Janicki <[email protected]> Co-authored-by: Mike <[email protected]> Co-authored-by: eliseacornejo <[email protected]> Co-authored-by: Sergio Vera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://main--aem-boilerplate--adobe.hlx.page/drafts/uncled/index-fragment
vs.
https://auto-blocking-example--aem-boilerplate--adobe.hlx.page/drafts/uncled/index-fragment
this removes the hero auto blocking and adds fragment auto-blocking...
the changes in
aem.jsare only for illustration purposes and will be removed from the PR.