-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Open
Open
field components should consistently support isReadOnly and isRequired render-props+data-attributes#6151
Feature
Copy link
Labels
Description
Provide a general summary of the feature here
this is continuing #5930 (comment)
field components (i.e. those which can be used in a form) should consistently support disabled/invalid/readonly/required props, render-props, and data attributes.
i have tried to list the current support here (although not every case may make sense to support). also, i have not yet created a separate table for data-attributes, but it seems that these match render-props support:
props
RAC | isDisabled | isInvalid | isReadOnly | isRequired |
---|---|---|---|---|
CheckboxGroup | ✅ | ✅ | ✅ | ✅ |
ComboBox | ✅ | ✅ | ✅ | ✅ |
Date/TimeField | ✅ | ✅ | ✅ | ✅ |
NumberField | ✅ | ✅ | ✅ | ✅ |
RadioGroup | ✅ | ✅ | ✅ | ✅ |
SearchField | ✅ | ✅ | ✅ | ✅ |
Select | ✅ | ✅ | ❌ | ✅ |
Slider | ✅ | ❌ | ❌ | ❌ |
Switch | ✅ | ❌ | ✅ | ❌ |
TextField | ✅ | ✅ | ✅ | ✅ |
render props
RAC | isDisabled | isInvalid | isReadOnly | isRequired |
---|---|---|---|---|
CheckboxGroup | ✅ | ✅ | ✅ | ✅ |
ComboBox | ✅ | ✅ | ❌ | ✅ |
Date/TimeField | ✅ | ✅ | ❌ | ❌ |
NumberField | ✅ | ✅ | ❌ | ✅ |
RadioGroup | ✅ | ✅ | ✅ | ✅ |
SearchField | ✅ | ✅ | ❌ | ❌ |
Select | ✅ | ✅ | ❌ | ✅ |
Slider | ✅ | ❌ | ❌ | ❌ |
Switch | ✅ | ❌ | ✅ | ❌ |
TextField | ✅ | ✅ | ✅ | ✅ |
🤔 Expected Behavior?
see above
😯 Current Behavior
see above
💁 Possible Solution
No response
🔦 Context
see above
💻 Examples
No response
🧢 Your Company/Team
No response
🕷 Tracking Issue
No response
sookmax, mwannewitz, artaommahe, Kegulf, Mr-Heidari and 1 more
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
✏️ To Groom