Skip to content

Switch to using yarl.URL.absolute over yarl.URL.is_absolute() #9171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2024
Merged

Switch to using yarl.URL.absolute over yarl.URL.is_absolute() #9171

merged 2 commits into from
Sep 18, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 18, 2024 •
edited
Loading

What do these changes do?

.absolute is directly cached and preferred

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

related issue #2779

@bdraco
Switch to using :attr:~yarl.URL.absolute over URL.is_absolute()
3ccd4e7 
.absolute is directly cached and preferred
@bdraco bdraco changed the title Switch to using :attr:~yarl.URL.absolute over URL.is_absolute() Switch to using yarl.URL.absolute over yarl.URL.is_absolute() Sep 18, 2024
@bdraco
Copy link
Member Author

bdraco commented Sep 18, 2024

not backported to 3.10 since the minimum yarl requirement is too old there

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 18, 2024
@bdraco bdraco marked this pull request as ready for review September 18, 2024 05:52
@codecov Codecov
Copy link

codecov bot commented Sep 18, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.31%. Comparing base (bf022b3) to head (1fc5ea2).
Report is 1048 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9171   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         107      107           
  Lines       34483    34483           
  Branches     4093     4093           
=======================================
  Hits        33901    33901           
  Misses        411      411           
  Partials      171      171
Flag Coverage Δ
CI-GHA 98.20% <100.00%> (ø)
OS-Linux 97.87% <100.00%> (ø)
OS-Windows 96.28% <100.00%> (ø)
OS-macOS 97.54% <100.00%> (ø)
Py-3.10.11 97.64% <100.00%> (ø)
Py-3.10.14 97.58% <100.00%> (ø)
Py-3.10.15 ?
Py-3.11.9 97.81% <100.00%> (ø)
Py-3.12.5 97.58% <100.00%> (ø)
Py-3.12.6 97.64% <100.00%> (ø)
Py-3.9.13 97.53% <100.00%> (ø)
Py-3.9.19 97.38% <100.00%> (-0.09%) ⬇️
Py-3.9.20 97.29% <100.00%> (-0.19%) ⬇️
Py-pypy7.3.16 97.08% <100.00%> (ø)
VM-macos 97.54% <100.00%> (ø)
VM-ubuntu 97.87% <100.00%> (ø)
VM-windows 96.28% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 0462ae6 into master Sep 18, 2024
35 of 36 checks passed
@bdraco bdraco deleted the absolute branch September 18, 2024 13:02
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 18, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/0462ae6be2d78223fbb06879b36c96ef8c1af07b/pr-9171

Backported as #9185

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 18, 2024
@bdraco @patchback
Switch to using yarl.URL.absolute over yarl.URL.is_absolute() (#9171
e7826b0 
)

(cherry picked from commit 0462ae6)
@patchback patchback bot mentioned this pull request Sep 18, 2024
Merged
bdraco added a commit that referenced this pull request Sep 18, 2024
@patchback @bdraco
[PR #9171/0462ae6b backport][3.11] Switch to using `yarl.URL.absolute…
71c47e4 
…` over `yarl.URL.is_absolute()` (#9185)

Co-authored-by: J. Nick Koston <[email protected]>
bdraco added a commit that referenced this pull request Sep 23, 2024
@bdraco
Revert "Switch to using yarl.URL.absolute over `yarl.URL.is_absolut…
7a4c527 
…e()` (#9171)"

This reverts commit 0462ae6.
bdraco added a commit that referenced this pull request Sep 23, 2024
@bdraco
Revert "Revert "Switch to using yarl.URL.absolute over `yarl.URL.is…
195e3f2 
…_absolute()` (#9171)""

This reverts commit 7a4c527.
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 24, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/0462ae6be2d78223fbb06879b36c96ef8c1af07b/pr-9171

Backported as #9291

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 24, 2024
@bdraco @patchback
Switch to using yarl.URL.absolute over yarl.URL.is_absolute() (#9171
944c47f 
)

(cherry picked from commit 0462ae6)
@patchback patchback bot mentioned this pull request Sep 24, 2024
Merged
bdraco added a commit that referenced this pull request Sep 24, 2024
@patchback @bdraco
[PR #9171/0462ae6b backport][3.10] Switch to using `yarl.URL.absolute…
e6bcfbe 
…` over `yarl.URL.is_absolute()` (#9291)

Co-authored-by: J. Nick Koston <[email protected]>
@achimnol achimnol mentioned this pull request Sep 30, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dreamsorcerer Dreamsorcerer Dreamsorcerer approved these changes

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdraco @Dreamsorcerer