Skip to content

Fix PublishWithAck response message type #7673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

Fix PublishWithAck response message type #7673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d55f77d
Fix PublishWithAck response message type
Arkatufus May 28, 2025
ece24ff
Update API Approval list
Arkatufus May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/contrib/cluster/Akka.Cluster.Tools/PublishSubscribe/DistributedMessages.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,9 +441,11 @@ public enum PublishFailReason
MediatorShuttingDown
}

public sealed record PublishFailed(PublishWithAck Message, PublishFailReason Reason): IDeadLetterSuppression;
public interface IPublishResponse;

public sealed record PublishSucceeded(PublishWithAck Message): IDeadLetterSuppression;
public sealed record PublishFailed(PublishWithAck Message, PublishFailReason Reason): IPublishResponse, IDeadLetterSuppression;

public sealed record PublishSucceeded(PublishWithAck Message): IPublishResponse, IDeadLetterSuppression;

/// <summary>
/// TBD
Expand Down
5 changes: 3 additions & 2 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.DotNet.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ namespace Akka.Cluster.Tools.PublishSubscribe
public static Akka.Cluster.Tools.PublishSubscribe.GetTopics Instance { get; }
}
public interface IDistributedPubSubMessage { }
public interface IPublishResponse { }
public sealed class Publish : Akka.Actor.IWrappedMessage, Akka.Cluster.Tools.PublishSubscribe.IDistributedPubSubMessage, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.Publish>
{
public Publish(string topic, object message, bool sendOneMessageToEachGroup = False) { }
Expand All @@ -297,13 +298,13 @@ namespace Akka.Cluster.Tools.PublishSubscribe
Timeout = 0,
MediatorShuttingDown = 1,
}
public sealed class PublishFailed : Akka.Event.IDeadLetterSuppression, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.PublishFailed>
public sealed class PublishFailed : Akka.Cluster.Tools.PublishSubscribe.IPublishResponse, Akka.Event.IDeadLetterSuppression, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.PublishFailed>
{
public PublishFailed(Akka.Cluster.Tools.PublishSubscribe.PublishWithAck Message, Akka.Cluster.Tools.PublishSubscribe.PublishFailReason Reason) { }
public Akka.Cluster.Tools.PublishSubscribe.PublishWithAck Message { get; set; }
public Akka.Cluster.Tools.PublishSubscribe.PublishFailReason Reason { get; set; }
}
public sealed class PublishSucceeded : Akka.Event.IDeadLetterSuppression, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.PublishSucceeded>
public sealed class PublishSucceeded : Akka.Cluster.Tools.PublishSubscribe.IPublishResponse, Akka.Event.IDeadLetterSuppression, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.PublishSucceeded>
{
public PublishSucceeded(Akka.Cluster.Tools.PublishSubscribe.PublishWithAck Message) { }
public Akka.Cluster.Tools.PublishSubscribe.PublishWithAck Message { get; set; }
Expand Down
5 changes: 3 additions & 2 deletions src/core/Akka.API.Tests/verify/CoreAPISpec.ApproveClusterTools.Net.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ namespace Akka.Cluster.Tools.PublishSubscribe
public static Akka.Cluster.Tools.PublishSubscribe.GetTopics Instance { get; }
}
public interface IDistributedPubSubMessage { }
public interface IPublishResponse { }
public sealed class Publish : Akka.Actor.IWrappedMessage, Akka.Cluster.Tools.PublishSubscribe.IDistributedPubSubMessage, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.Publish>
{
public Publish(string topic, object message, bool sendOneMessageToEachGroup = False) { }
Expand All @@ -297,13 +298,13 @@ namespace Akka.Cluster.Tools.PublishSubscribe
Timeout = 0,
MediatorShuttingDown = 1,
}
public sealed class PublishFailed : Akka.Event.IDeadLetterSuppression, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.PublishFailed>
public sealed class PublishFailed : Akka.Cluster.Tools.PublishSubscribe.IPublishResponse, Akka.Event.IDeadLetterSuppression, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.PublishFailed>
{
public PublishFailed(Akka.Cluster.Tools.PublishSubscribe.PublishWithAck Message, Akka.Cluster.Tools.PublishSubscribe.PublishFailReason Reason) { }
public Akka.Cluster.Tools.PublishSubscribe.PublishWithAck Message { get; set; }
public Akka.Cluster.Tools.PublishSubscribe.PublishFailReason Reason { get; set; }
}
public sealed class PublishSucceeded : Akka.Event.IDeadLetterSuppression, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.PublishSucceeded>
public sealed class PublishSucceeded : Akka.Cluster.Tools.PublishSubscribe.IPublishResponse, Akka.Event.IDeadLetterSuppression, System.IEquatable<Akka.Cluster.Tools.PublishSubscribe.PublishSucceeded>
{
public PublishSucceeded(Akka.Cluster.Tools.PublishSubscribe.PublishWithAck Message) { }
public Akka.Cluster.Tools.PublishSubscribe.PublishWithAck Message { get; set; }
Expand Down
Loading