Use svg-toolbelt to give zoom & pan controls to mermaid diagrams #5206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nder. * When mermaid diagrams are rendered they shouldn't be a code block anymore, so convert them to a div
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use svg-toolbelt to give mermaid diagrams pan and zoom controls. This is especially useful since our diagrams render at a fixed width of about 760px in the manual, so any reasonably sized diagram rendered by mermaidjs is unreadable.
As an addition, when we render the mermaid code block, a code tag is no longer appropriate since we are displaying an svg instead, so I've switched out the code block for a div.