Fix UTF8 escapes in character classes #106
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlopain
commented
Aug 27, 2025
lib/regexp_parser/scanner/scanner.rl
Outdated
| # (This currently includes \^, \-, \&, \:, although these could potentially | ||
| # be meta chars when not escaped, depending on their position in the set.) | ||
| any > (escaped_set_alpha, 1) { | ||
| any > (escaped_set_alpha, 1) | utf8_multibyte > (escaped_alpha, 1) { |
There was a problem hiding this comment.
This also works but no tests fail. I mimicked it over to utf8_multibyte for consistency but I'm not really sure what it is supposed to do:
Suggested change
| any > (escaped_set_alpha, 1) | utf8_multibyte > (escaped_alpha, 1) { | |
| any | utf8_multibyte { |
In fact, ragel doesn't seem to produce different output with or without it
Otherwise one character gets split up into its individual bytes
Earlopain
force-pushed
the
fix-utf8-escapes-in-sets
branch
from
bc5f0e4 to
2efa904
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #104, I think I found the fix myself 💪
Otherwise one character gets split up into its individual bytes.