feat(material/dialog): Let types flow to MatDialogConfig.closePredicate()
#31892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate()` WIP The goal is to be able to use `MatDialogConfig.closePredicate()` with proper typing without repeating them, or without any casting. This is a work in progress, because even though the modified test would compile, and most likely pass, other places in the codebase are broken by the breaking change introduced in `MatDialogConfig`. So I would like to ask the opinion of the Angular team here. Is there any chance to have something similar merged, if it gets polished up ? Fixes angular#31873
angular-robot
bot
added
detected: feature
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to be able to use
MatDialogConfig.closePredicate()with proper typing without repeating them, or without any casting.This is a work in progress, because even though the modified test would compile, and most likely pass, other places in the codebase are broken by the breaking change introduced in
MatDialogConfig. So I would like to ask the opinion of the Angular team here. Is there any chance to have something similar merged, if it gets polished up ?Fixes #31873
@crisbeto, since you wrote that code originally, in #30919, do you have any thoughts to share on this ?