fix: handle apostrophes for names ending in x #4343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@malgokiel is attempting to deploy a commit to the github readme stats Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
the
stats-card
qwerty541
approved these changes
Sep 10, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes apostrophe placement in GitHub stats card names ending with "x" to follow proper English grammar rules. Previously, names ending in "x" incorrectly had no apostrophe-s added, but according to English grammar rules, only names ending in "s" should omit the additional "s".
- Updated apostrophe logic to only check for names ending in "s" instead of both "s" and "x"
- Modified test case expectation for "Felix" to show "Felix's" instead of "Felix'"
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/cards/stats.js | Updated apostrophe logic to use regex checking only for "s" endings |
| tests/renderStatsCard.test.js | Updated test expectation for "Felix" to include apostrophe-s |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Hello @malgokiel Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4232
This fixes the apostrophe placement in names ending with "x" so it matches the grammar rules.
Test case was also updated.