Skip to content

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Jan 17, 2025

Backport #44908 to Airflow 2.11

Closes: #45632


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@Lee-W Lee-W force-pushed the back-port-airflow-config-lint branch 2 times, most recently from b55c37c to 1736070 Compare January 17, 2025 09:58
@Lee-W Lee-W requested review from sunank200 and uranusjr January 17, 2025 09:58
@Lee-W Lee-W force-pushed the back-port-airflow-config-lint branch 2 times, most recently from df6a3e4 to fae3df8 Compare January 24, 2025 03:19
@Lee-W Lee-W force-pushed the back-port-airflow-config-lint branch from fae3df8 to 7c3305c Compare February 4, 2025 07:36
@Lee-W Lee-W requested a review from amoghrajesh February 5, 2025 13:39
Copy link
Collaborator

@sunank200 sunank200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good but do we need to add docs?

@Lee-W
Copy link
Member Author

Lee-W commented Feb 14, 2025

Overall looks good but do we need to add docs?

Yep, I'll also check whether there're config in main that has not yet been ported here

@Lee-W
Copy link
Member Author

Lee-W commented Feb 14, 2025

Overall looks good but do we need to add docs?

I just noticed we don't have it in the main, either. Probably a good idea to add a doc to main and then backport to this one. I'll create an issue for tracking it

@Lee-W Lee-W merged commit bbded79 into apache:v2-10-test Feb 14, 2025
42 checks passed
@Lee-W Lee-W deleted the back-port-airflow-config-lint branch February 14, 2025 10:37
@Lee-W
Copy link
Member Author

Lee-W commented Feb 14, 2025

forget to push the latest changes......

@Lee-W
Copy link
Member Author

Lee-W commented Feb 14, 2025

follow up PR #46757

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants