-
Notifications
You must be signed in to change notification settings - Fork 15.6k
Update docs to ensure Airflow 2 plugins are converted to 3 before migration #49614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Not really. AF2 plugins works to an extend but require the fab provider to be installed. Maybe we need a line explaining that. (AF2 plugins will required fab-provider, even if the exception message is self explanatory) |
Co-authored-by: Pierre Jeambrun <[email protected]>
Do we have some documentation on differences in detail? This is likely too verbose to be called out in the notes, but a dedicated page would be helpful. |
I think we had a plugin's docs. I will check. |
Yes, you're right about FAB. I mentioned this in the issue — it’s all due to FAB. However, I didn’t add that the FAB installation instructions in the docs, and with Airflow 3, we don't encourage that. A better approach might be to convert it to the Airflow 3 style of plugins. WDYT, @pierrejeambrun?
|
Yes converting plugins to AF3 style is the 'best' approach, but I don't think this is possible for everyone in a short term to do so. If the upgrading document state that "you need to rewrite your plugins to AF3 style" it might be a blocker. As least mentioning that there is a workaround (limited support) via the fab provider is worth mentioning. |
There is some related docs there too, but I think the upgrade document is a good place to start. As mentioned by TP, we might want a dedicated upgrade document / comparison for AF2 <=> AF3 plugins. (but that could be a follow up PR) |
Updated @pierrejeambrun |
…ration (#49614) * update how to docs to convert plugins to airflow3 * Update airflow-core/docs/installation/upgrading_to_airflow3.rst Co-authored-by: Pierre Jeambrun <[email protected]> * update docs --------- Co-authored-by: Pierre Jeambrun <[email protected]> (cherry picked from commit 02b6eb6)
…ration (apache#49614) * update how to docs to convert plugins to airflow3 * Update airflow-core/docs/installation/upgrading_to_airflow3.rst Co-authored-by: Pierre Jeambrun <[email protected]> * update docs --------- Co-authored-by: Pierre Jeambrun <[email protected]>
related: #49613
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.