Skip to content

Conversation

vatsrahul1001
Copy link
Contributor

related: #49613

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

pierrejeambrun
pierrejeambrun previously approved these changes Apr 23, 2025
@pierrejeambrun
Copy link
Member

pierrejeambrun commented Apr 23, 2025

Not really. AF2 plugins works to an extend but require the fab provider to be installed.

Maybe we need a line explaining that. (AF2 plugins will required fab-provider, even if the exception message is self explanatory)

@uranusjr
Copy link
Member

Do we have some documentation on differences in detail? This is likely too verbose to be called out in the notes, but a dedicated page would be helpful.

@vatsrahul1001
Copy link
Contributor Author

Do we have some documentation on differences in detail? This is likely too verbose to be called out in the notes, but a dedicated page would be helpful.

I think we had a plugin's docs. I will check.

@vatsrahul1001
Copy link
Contributor Author

vatsrahul1001 commented Apr 23, 2025

#49613

Yes, you're right about FAB. I mentioned this in the issue — it’s all due to FAB. However, I didn’t add that the FAB installation instructions in the docs, and with Airflow 3, we don't encourage that. A better approach might be to convert it to the Airflow 3 style of plugins. WDYT, @pierrejeambrun?

Not really. AF2 plugins works to an extend but require the fab provider to be installed.

Maybe we need a line explaining that. (AF2 plugins will required fab-provider, even if the exception message is self explanatory)

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Apr 23, 2025

Yes converting plugins to AF3 style is the 'best' approach, but I don't think this is possible for everyone in a short term to do so.

If the upgrading document state that "you need to rewrite your plugins to AF3 style" it might be a blocker. As least mentioning that there is a workaround (limited support) via the fab provider is worth mentioning.

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Apr 23, 2025

There is some related docs there too, but I think the upgrade document is a good place to start. As mentioned by TP, we might want a dedicated upgrade document / comparison for AF2 <=> AF3 plugins. (but that could be a follow up PR)
https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-view-plugin.rst

@vatsrahul1001
Copy link
Contributor Author

Yes converting plugins to AF3 style is the 'best' approach, but I don't think this is possible for everyone in a short term to do so.

If the upgrading document state that "you need to rewrite your plugins to AF3 style" it might be a blocker. As least mentioning that there is a workaround (limited support) via the fab provider is worth mentioning.

Updated @pierrejeambrun

@vatsrahul1001 vatsrahul1001 requested a review from phanikumv April 23, 2025 12:55
@phanikumv phanikumv merged commit 02b6eb6 into apache:main Apr 23, 2025
51 checks passed
@phanikumv phanikumv deleted the update-docs branch April 23, 2025 13:01
@kaxil kaxil added this to the Airflow 3.0.1 milestone Apr 23, 2025
kaxil pushed a commit that referenced this pull request Apr 23, 2025
…ration (#49614)

* update how to docs to convert plugins to airflow3

* Update airflow-core/docs/installation/upgrading_to_airflow3.rst

Co-authored-by: Pierre Jeambrun <[email protected]>

* update docs

---------

Co-authored-by: Pierre Jeambrun <[email protected]>
(cherry picked from commit 02b6eb6)
prabhusneha pushed a commit to astronomer/airflow that referenced this pull request Apr 25, 2025
…ration (apache#49614)

* update how to docs to convert plugins to airflow3

* Update airflow-core/docs/installation/upgrading_to_airflow3.rst

Co-authored-by: Pierre Jeambrun <[email protected]>

* update docs

---------

Co-authored-by: Pierre Jeambrun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants