Fall back when a task cannot be expanded #49772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
requested review from
ephraimbuddy,
pierrejeambrun,
rawwar,
jason810496,
bugraoz93 and
shubhamraj-git
as code owners
2 tasks
phanikumv
approved these changes
Apr 25, 2025
tirkarthi
approved these changes
Apr 25, 2025
|
Test failures seem to be unrelated. Maybe update the branch with main to give it a try? |
When rendering a dag in the API, we must take account for cases when a mapped task cannot be expanded, either due to the upstream has not been resolved, or cannot provide a value due to failure. When this happens, we simply count 1 ti for the unexpanded task. This is how the scheduler represent the task internally, and should be a good enough value for UI representation.
uranusjr
force-pushed
the
api-not-crash-for-unexpanded
branch
from
ccbd65a to
4d6de80
Compare
|
Looks like the docker compose thing is failing everywhere. I’ll ignore it. |
kaxil
pushed a commit
that referenced
this pull request
Apr 26, 2025
(cherry picked from commit 19122e7)
jroachgolf84
pushed a commit
to jroachgolf84/airflow
that referenced
this pull request
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering a dag in the API, we must take account for cases when a mapped task cannot be expanded, either due to the upstream has not been resolved, or cannot provide a value due to failure.
When this happens, we simply count 1 ti for the unexpanded task. This is how the scheduler represent the task internally, and should be a good enough value for UI representation.
Close #48786.