-
Notifications
You must be signed in to change notification settings - Fork 15.6k
Fix gcp remote log module import in airflow local settings #49788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
airflow-core/src/airflow/config_templates/airflow_local_settings.py
Outdated
Show resolved
Hide resolved
0cf10bc
to
6ff735a
Compare
This needs to go v3-0-test ryt? |
6ff735a
to
1e92e5a
Compare
#49788) (cherry picked from commit f81cd6f) Co-authored-by: GPK <[email protected]>
apache#49788) (cherry picked from commit f81cd6f) Co-authored-by: GPK <[email protected]>
#49788) (#49802) (cherry picked from commit f81cd6f) Co-authored-by: GPK <[email protected]>
Any chance this gets released soon? We had high hopes for Airflow 3.0, but the upgrade is blocked because of this issue :( |
3.0.1 will be released on 7th May, so not too far now. Btw you can also apply patch since it is just 1-liner |
I tried to update the local settings to fix the import error but then I ran into:
Same conn_id I always used in Airflow 2. I don't have any of those things defined since I just use Workload Identity and add the service account annotations. |
How your configuring this one? You need to set them in the logging section in conf with |
Well, 3.0.1 has the very same error that @ldacey posted... |
There is no keyfile dict or keyfile path though, so hopefully we can pass null or an empty string. Even if we were not using workload identity, I would assume this information would be retrieved from the gcp_conn_id? We wouldn't add sensitive information like the keyfile dict to the values.yaml. |
This should solve the above case #50590 If you want to workout now before that change released. you can do like this.
|
that's what I did, but workers are still struggling to get the data shipped to GCS: |
yeah thats because of the recent provider changes not released yet. |
Gcp log module path pointed to logs. causing ModuleNotFoundError.
User reported in slack. https://apache-airflow.slack.com/archives/CCQ7EGB1P/p1745522030825469
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.