Update max_consecutive_failed_dag_runs default value to zero in TaskSDK dag #49795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gopidesupavan
requested review from
ashb,
kaxil,
amoghrajesh and
XD-DENG
as code owners
potiuk
approved these changes
Apr 25, 2025
amoghrajesh
approved these changes
Apr 25, 2025
hussein-awala
approved these changes
Apr 25, 2025
|
Should be 3.0.1 -> I cherry-pick it manually |
potiuk
pushed a commit
to potiuk/airflow
that referenced
this pull request
Apr 25, 2025
…ero in TaskSDK dag (apache#49795) * Update max_consecutive_failed_dag_runs default value to zero in TaskSDK dag * Update max_consecutive_failed_dag_runs default value to zero in TaskSDK dag (cherry picked from commit 59e7606) Co-authored-by: GPK <[email protected]>
potiuk
added a commit
that referenced
this pull request
Apr 26, 2025
…ero in TaskSDK dag (#49795) (#49803) * Update max_consecutive_failed_dag_runs default value to zero in TaskSDK dag * Update max_consecutive_failed_dag_runs default value to zero in TaskSDK dag (cherry picked from commit 59e7606) Co-authored-by: GPK <[email protected]>
Oh thank you :) |
jroachgolf84
pushed a commit
to jroachgolf84/airflow
that referenced
this pull request
Apr 30, 2025
…DK dag (apache#49795) * Update max_consecutive_failed_dag_runs default value to zero in TaskSDK dag * Update max_consecutive_failed_dag_runs default value to zero in TaskSDK dag
gopidesupavan
deleted the
update-max-consecutive-failed-dag-runs-value-in-task-sdk
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default value of -1 was initially introduced in the serialization side for TaskSDK DAGs. However, in the core model/dag.py, the default is set to 0 https://github.com/apache/airflow/blob/main/airflow-core/src/airflow/models/dag.py#L438. To maintain consistency, we're aligning both places to use a default of zero.
As discussed in #49647 (comment), we're reverting back to a default of zero. This change will eliminate the need for special-case validation logic, like this one we did here https://github.com/apache/airflow/pull/49647/files#diff-00ea1b4e006d5e9279447a80e851071697d35ffe08525e3ca20a651599bbf77fR689.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.