Create a timezone-aware datetime input component #49911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested review from
pierrejeambrun,
ryanahamilton,
jscheffl and
shubhamraj-git
as code owners
jscheffl
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
I was wondering that compared to the "normal" control it is just a text field w/o calendar pop-up. I once researched but could not find a good base component. Is it really that ReactJS community does not have a proper control for date/time/timezone selection?
pierrejeambrun
approved these changes
Apr 29, 2025
mvfc
pushed a commit
to mvfc/airflow
that referenced
this pull request
Apr 29, 2025
mvfc
pushed a commit
to mvfc/airflow
that referenced
this pull request
Apr 29, 2025
jroachgolf84
pushed a commit
to jroachgolf84/airflow
that referenced
this pull request
Apr 30, 2025
kaxil
pushed a commit
that referenced
this pull request
Apr 30, 2025
(cherry picked from commit 935c49d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring the changes from #49662 into a reusable component to use for all our datetime-local inputs.
Closes #49462
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.