Use latest bundle version when clearing / re-running dag #50040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstandish
force-pushed
the
use-latest-bundle-version-when-clearing
branch
from
be9640d to
4bc265d
Compare
dstandish
added a commit
to astronomer/airflow
that referenced
this pull request
Apr 30, 2025
Making dag required helps me in apache#50040. It's always passed in all production code so, we can make the change. Should be thought of as private anyway. And making it kwarg only, well why not.
uranusjr
reviewed
May 2, 2025
uranusjr
reviewed
May 2, 2025
dstandish
force-pushed
the
use-latest-bundle-version-when-clearing
branch
from
4bc265d to
a9d9a3b
Compare
dstandish
requested review from
ephraimbuddy,
pierrejeambrun,
rawwar,
jason810496,
bugraoz93 and
shubhamraj-git
as code owners
dstandish
force-pushed
the
use-latest-bundle-version-when-clearing
branch
2 times, most recently
from
2e5cfa9 to
4ff97f8
Compare
ephraimbuddy
reviewed
May 6, 2025
ephraimbuddy
reviewed
May 6, 2025
Right -- understandable. My thinking is that it was not intentional to make that a public function, and that I am "fixing" that in this patch release. |
The function has been around for a while(Airflow 2 or 1 not sure) and it looks like people use it in their DAGs e.g #30237 and #19329 (comment) |
|
Btw |
dstandish
added
the
full tests needed
dstandish
force-pushed
the
use-latest-bundle-version-when-clearing
branch
from
79ac45b to
bcaa368
Compare
uranusjr
approved these changes
May 7, 2025
bugraoz93
approved these changes
May 7, 2025
When clearing a dag to be rerun, if the bundle is versioned, and bundle versioning is enabled for the dag, we should clear the bundle version (of the dag run) to be the latest bundle version seen for the dag. I removed the dag param. There's not much point in passing dag in as a param to this function since the TIs can be from different dags, so we have to look it up anyway. Moreover, they can be from different serdags associated with the same dag -- and that in particular is what makes this complicated and required me to go and use the SchedulerDagBag object.
dstandish
force-pushed
the
use-latest-bundle-version-when-clearing
branch
from
7f19372 to
619938f
Compare
kaxil
pushed a commit
that referenced
this pull request
May 12, 2025
Co-authored-by: Tzu-ping Chung <[email protected]> (cherry picked from commit c069401)
dstandish
added
the
backport-to-v3-0-test
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
Co-authored-by: Tzu-ping Chung <[email protected]> (cherry picked from commit c069401)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use latest bundle version when clearing / re-running dag
When clearing a dag to be rerun, if the bundle is versioned, and bundle versioning is enabled for the dag, we should clear the bundle version (of the dag run) to be the latest bundle version seen for the dag.
I removed the dag param. There's not much point in passing dag in as a param to this function since the TIs can be from different dags, so we have to look it up anyway.
Moreover, they can be from different serdags associated with the same dag -- and that in particular is what makes this complicated and required me to go and use the SchedulerDagBag object.
Most of the ugliness of this PR comes from the fact that it requires that there be serialized dags which we sometimes do not create in our tests -- but which are always going to be there in production. And when I enable them in the test code, then it tends to require changes to the tests.
resolves: #49639