Add webserver_config.py file to api-server #50108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humit0
requested review from
dstandish,
jedcunningham and
hussein-awala
as code owners
vincbeck
approved these changes
May 12, 2025
eladkal
force-pushed
the
add-webserver-config
branch
from
67bc662 to
0bbbf43
Compare
Co-authored-by: rom sharon <[email protected]>
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
* Add webserver_config.py file to api-server * update example of apiServerConfigConfigMapName Co-authored-by: rom sharon <[email protected]> --------- Co-authored-by: rom sharon <[email protected]>
25 tasks
GrumpyCat51
reviewed
Jun 19, 2025
| @@ -582,6 +582,17 @@ server_tls_key_file = /etc/pgbouncer/server.key | |||
| readOnly: True | |||
| {{- end }} | |||
|
|
|||
| {{- define "airflow_api_server_config_configmap_name" -}} | |||
| {{- default (printf "%s-api-server-config" .Release.Name) .Values.webserver.webserverConfigConfigMapName }} | |||
There was a problem hiding this comment.
This points to the wrong section in the values file. I'll include the fix in a new MR
jose-lehmkuhl
pushed a commit
to jose-lehmkuhl/airflow
that referenced
this pull request
Jul 11, 2025
* Add webserver_config.py file to api-server * update example of apiServerConfigConfigMapName Co-authored-by: rom sharon <[email protected]> --------- Co-authored-by: rom sharon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the api-server component did not include webserver_config.py, making it impossible to configure settings such as LDAP or OAuth2 authentication.
This implementation references the existing method used by the webserver component.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.