Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -16,38 +16,34 @@
* specific language governing permissions and limitations
* under the License.
*/
import { Box, Text, HStack, Code } from "@chakra-ui/react";
import { Box, Text, HStack } from "@chakra-ui/react";
import { FiDatabase } from "react-icons/fi";
import { Link } from "react-router-dom";

import type { AssetEventResponse } from "openapi/requests/types.gen";
import Time from "src/components/Time";
import { Tooltip } from "src/components/ui";

import RenderedJsonField from "../RenderedJsonField";
import { TriggeredRuns } from "./TriggeredRuns";

export const AssetEvent = ({
assetId,
event,
showExtra,
}: {
readonly assetId?: number;
readonly event: AssetEventResponse;
readonly showExtra?: boolean;
}) => {
let source = "";

// eslint-disable-next-line @typescript-eslint/naming-convention
const { from_rest_api, from_trigger, ...extra } = event.extra ?? {};
const { from_rest_api: fromRestAPI, from_trigger: fromTrigger, ...extra } = event.extra ?? {};

if (from_rest_api === true) {
if (fromRestAPI === true) {
source = "API";
} else if (from_trigger === true) {
} else if (fromTrigger === true) {
source = "Trigger";
}

const extraString = JSON.stringify(extra);

return (
<Box borderBottomWidth={1} fontSize={13} mt={1} p={2}>
<Text fontWeight="bold">
Expand Down Expand Up @@ -86,7 +82,9 @@ export const AssetEvent = ({
<HStack>
<TriggeredRuns dagRuns={event.created_dagruns} />
</HStack>
{showExtra && extraString !== "{}" ? <Code>{extraString}</Code> : undefined}
{Object.keys(extra).length >= 1 ? (
<RenderedJsonField content={extra} jsonProps={{ collapsed: true }} />
) : undefined}
</Box>
);
};
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ import { DataTable } from "../DataTable";
import type { CardDef, TableState } from "../DataTable/types";
import { AssetEvent } from "./AssetEvent";

const cardDef = (assetId?: number, showExtra?: boolean): CardDef<AssetEventResponse> => ({
card: ({ row }) => <AssetEvent assetId={assetId} event={row} showExtra={showExtra} />,
const cardDef = (assetId?: number): CardDef<AssetEventResponse> => ({
card: ({ row }) => <AssetEvent assetId={assetId} event={row} />,
meta: {
customSkeleton: <Skeleton height="120px" width="100%" />,
},
Expand All @@ -42,7 +42,6 @@ type AssetEventProps = {
readonly isLoading?: boolean;
readonly setOrderBy?: (order: string) => void;
readonly setTableUrlState?: (state: TableState) => void;
readonly showExtra?: boolean;
readonly tableUrlState?: TableState;
readonly title?: string;
};
Expand All @@ -53,7 +52,6 @@ export const AssetEvents = ({
isLoading,
setOrderBy,
setTableUrlState,
showExtra,
tableUrlState,
title,
}: AssetEventProps) => {
Expand Down Expand Up @@ -100,7 +98,7 @@ export const AssetEvents = ({
)}
</Flex>
<DataTable
cardDef={cardDef(assetId, showExtra)}
cardDef={cardDef(assetId)}
columns={[]}
data={data?.asset_events ?? []}
displayMode="card"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const RenderedJsonField = ({ content, jsonProps, ...rest }: Props) => {
{...jsonProps}
/>
<ClipboardRoot value={contentFormatted}>
<ClipboardIconButton />
<ClipboardIconButton h={7} minW={7} />
</ClipboardRoot>
</Flex>
);
Expand Down
1 change: 0 additions & 1 deletion airflow-core/src/airflow/ui/src/pages/Asset/Asset.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ export const Asset = () => {
isLoading={isLoadingEvents}
setOrderBy={setOrderBy}
setTableUrlState={setTableURLState}
showExtra
tableUrlState={tableURLState}
/>
</Box>
Expand Down