Update BulkVariableService to support JSON serialization #51057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guan404ming
requested review from
ephraimbuddy,
pierrejeambrun,
rawwar,
jason810496,
bugraoz93 and
shubhamraj-git
as code owners
rawwar
approved these changes
May 25, 2025
bugraoz93
approved these changes
May 26, 2025
shubhamraj-git
approved these changes
May 26, 2025
guan404ming
force-pushed
the
fix-json-serialization
branch
from
0e056ae to
358804a
Compare
pierrejeambrun
added
the
backport-to-v3-0-test
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2025
…51057) (cherry picked from commit 1a34a42) Co-authored-by: Guan Ming(Wesley) Chiu <[email protected]>
Backport successfully created: v3-0-test
|
|
Thanks for all reviews. |
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
May 27, 2025
…pache#51057) (cherry picked from commit 1a34a42) Co-authored-by: Guan Ming(Wesley) Chiu <[email protected]>
github-actions bot
pushed a commit
to guan404ming/airflow
that referenced
this pull request
May 27, 2025
…pache#51057) (cherry picked from commit 1a34a42) Co-authored-by: Guan Ming(Wesley) Chiu <[email protected]>
pierrejeambrun
pushed a commit
that referenced
this pull request
May 27, 2025
…51057) (#51111) (cherry picked from commit 1a34a42) Co-authored-by: Guan Ming(Wesley) Chiu <[email protected]>
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
…51057) (#51111) (cherry picked from commit 1a34a42) Co-authored-by: Guan Ming(Wesley) Chiu <[email protected]>
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
jose-lehmkuhl
pushed a commit
to jose-lehmkuhl/airflow
that referenced
this pull request
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
fixes #51052
cc @pierrejeambrun @bugraoz93
Why
The API doesn’t explicitly serialize them as JSON when saving these variables. Instead, Python’s built-in str() function is used to convert the object and str() defaults to using single quotes.
How
Before saving a variable, it checks the value’s type. If the value is a dict or list, call
Variable.setwith serialize_json=True to ensure thatjson.dumpsis used for proper JSON serialization.before
Screen.Recording.2025-05-26.at.1.44.03.AM.mov
after
Screen.Recording.2025-05-26.at.1.46.34.AM.mov
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.