Bring back "standard" example dags to the airflow-core package #51192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we are working on a longer-term solution for example-dags, the short-term one is to bring the standard example_dags back to the airflow-core via symbolic link to the standard package folder. This makes the dags to be copied to the airflow-core from the latest main version (but those dags don't change) while not requiring to duplicate the dags and keep them in standard provider where the documentation for them is kept.
potiuk
force-pushed
the
bring-back-standard-exeamples-to-airflow-package
branch
from
b1c73d0 to
3ff93fa
Compare
potiuk
requested review from
jedcunningham,
ephraimbuddy,
XD-DENG and
ashb
as code owners
potiuk
added
the
backport-to-v3-0-test
This was referenced May 29, 2025
jscheffl
approved these changes
May 29, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 29, 2025
…ckage (#51192) As we are working on a longer-term solution for example-dags, the short-term one is to bring the standard example_dags back to the airflow-core via symbolic link to the standard package folder. This makes the dags to be copied to the airflow-core from the latest main version (but those dags don't change) while not requiring to duplicate the dags and keep them in standard provider where the documentation for them is kept. (cherry picked from commit 46908a1) Co-authored-by: Jarek Potiuk <[email protected]> Co-authored-by: Kaxil Naik <[email protected]>
Backport successfully created: v3-0-test
|
potiuk
added a commit
that referenced
this pull request
May 29, 2025
…ckage (#51192) (#51220) As we are working on a longer-term solution for example-dags, the short-term one is to bring the standard example_dags back to the airflow-core via symbolic link to the standard package folder. This makes the dags to be copied to the airflow-core from the latest main version (but those dags don't change) while not requiring to duplicate the dags and keep them in standard provider where the documentation for them is kept. (cherry picked from commit 46908a1) Co-authored-by: Jarek Potiuk <[email protected]> Co-authored-by: Kaxil Naik <[email protected]>
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 31, 2025
Folow up after apache#51192. Actually choosing the same approach as for system tests was pretty wrong and even before attempting to have final solution for example_dags/system tests we should move the standard examples out of "tests.system" as rightfully pointed out by Jed in the apache#51192. The snippets of code to run the tests as pytests are not neeeded and they are actually even harmful as they cause import errors when no tests_common is around
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 31, 2025
Folow up after apache#51192. Actually choosing the same approach as for system tests was pretty wrong and even before attempting to have final solution for example_dags/system tests we should move the standard examples out of "tests.system" as rightfully pointed out by Jed in the apache#51192. The snippets of code to run the tests as pytests are not neeeded and they are actually even harmful as they cause import errors when no tests_common is around
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
May 31, 2025
Folow up after apache#51192. Actually choosing the same approach as for system tests was pretty wrong and even before attempting to have final solution for example_dags/system tests we should move the standard examples out of "tests.system" as rightfully pointed out by Jed in the apache#51192. The snippets of code to run the tests as pytests are not neeeded and they are actually even harmful as they cause import errors when no tests_common is around
potiuk
added a commit
that referenced
this pull request
Jun 1, 2025
…1260) Folow up after #51192. Actually choosing the same approach as for system tests was pretty wrong and even before attempting to have final solution for example_dags/system tests we should move the standard examples out of "tests.system" as rightfully pointed out by Jed in the #51192. The snippets of code to run the tests as pytests are not neeeded and they are actually even harmful as they cause import errors when no tests_common is around
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Jun 1, 2025
… sources (apache#51260) Folow up after apache#51192. Actually choosing the same approach as for system tests was pretty wrong and even before attempting to have final solution for example_dags/system tests we should move the standard examples out of "tests.system" as rightfully pointed out by Jed in the apache#51192. The snippets of code to run the tests as pytests are not neeeded and they are actually even harmful as they cause import errors when no tests_common is around (cherry picked from commit cc29e02) Co-authored-by: Jarek Potiuk <[email protected]>
potiuk
added a commit
that referenced
this pull request
Jun 1, 2025
… sources (#51260) (#51275) Folow up after #51192. Actually choosing the same approach as for system tests was pretty wrong and even before attempting to have final solution for example_dags/system tests we should move the standard examples out of "tests.system" as rightfully pointed out by Jed in the #51192. The snippets of code to run the tests as pytests are not neeeded and they are actually even harmful as they cause import errors when no tests_common is around (cherry picked from commit cc29e02)
kaxil
added a commit
that referenced
this pull request
Jun 3, 2025
…ckage (#51192) (#51220) As we are working on a longer-term solution for example-dags, the short-term one is to bring the standard example_dags back to the airflow-core via symbolic link to the standard package folder. This makes the dags to be copied to the airflow-core from the latest main version (but those dags don't change) while not requiring to duplicate the dags and keep them in standard provider where the documentation for them is kept. (cherry picked from commit 46908a1) Co-authored-by: Jarek Potiuk <[email protected]> Co-authored-by: Kaxil Naik <[email protected]>
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
… sources (#51260) (#51275) Folow up after #51192. Actually choosing the same approach as for system tests was pretty wrong and even before attempting to have final solution for example_dags/system tests we should move the standard examples out of "tests.system" as rightfully pointed out by Jed in the #51192. The snippets of code to run the tests as pytests are not neeeded and they are actually even harmful as they cause import errors when no tests_common is around (cherry picked from commit cc29e02)
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
…e#51192) As we are working on a longer-term solution for example-dags, the short-term one is to bring the standard example_dags back to the airflow-core via symbolic link to the standard package folder. This makes the dags to be copied to the airflow-core from the latest main version (but those dags don't change) while not requiring to duplicate the dags and keep them in standard provider where the documentation for them is kept. Co-authored-by: Kaxil Naik <[email protected]>
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
…ache#51260) Folow up after apache#51192. Actually choosing the same approach as for system tests was pretty wrong and even before attempting to have final solution for example_dags/system tests we should move the standard examples out of "tests.system" as rightfully pointed out by Jed in the apache#51192. The snippets of code to run the tests as pytests are not neeeded and they are actually even harmful as they cause import errors when no tests_common is around
jose-lehmkuhl
pushed a commit
to jose-lehmkuhl/airflow
that referenced
this pull request
Jul 11, 2025
…e#51192) As we are working on a longer-term solution for example-dags, the short-term one is to bring the standard example_dags back to the airflow-core via symbolic link to the standard package folder. This makes the dags to be copied to the airflow-core from the latest main version (but those dags don't change) while not requiring to duplicate the dags and keep them in standard provider where the documentation for them is kept. Co-authored-by: Kaxil Naik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we are working on a longer-term solution for example-dags, the short-term one is to bring the standard example_dags back to the airflow-core via symbolic link to the standard package folder.
This makes the dags to be copied to the airflow-core from the latest main version (but those dags don't change) while not requiring to duplicate the dags and keep them in standard provider where the documentation for them is kept.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.