Chart: Always deploy jwt secret #51799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While using a pre-install hook is nice since the secret doesn't change, the downside is on upgrade the jwt secret will never be added. As this is a new secret for 3.0, that is more problematic than having a changing secret. Plus, it's best practice to set this explicitly anyway.
eladkal
approved these changes
Jun 16, 2025
25 tasks
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Jun 17, 2025
While using a pre-install hook is nice since the secret doesn't change, the downside is on upgrade the jwt secret will never be added. As this is a new secret for 3.0, that is more problematic than having a changing secret. Plus, it's best practice to set this explicitly anyway.
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Jun 21, 2025
While using a pre-install hook is nice since the secret doesn't change, the downside is on upgrade the jwt secret will never be added. As this is a new secret for 3.0, that is more problematic than having a changing secret. Plus, it's best practice to set this explicitly anyway.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using a pre-install hook is nice since the secret doesn't change, the downside is on upgrade the jwt secret will never be added. As this is a new secret for 3.0, that is more problematic than having a changing secret. Plus, it's best practice to set this explicitly anyway.
Follow up of #49923.