[v3-0-test] Fix lingering task supervisors when EOF is missed (#51180)
#51970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…1180) closes #50500 Adds a new safeguard for cases where the task subprocess closes before all pipe sockets send EOF. The supervisor now records the process exit time and forcibly closes any sockets still open after `workers.socket_cleanup_timeout`. This stops the supervisor loop from hanging indefinitely and allows the process to exit cleanly. (cherry picked from commit a2651f1) Co-authored-by: Kaxil Naik <[email protected]>
amoghrajesh
approved these changes
Jun 20, 2025
hussein-awala
approved these changes
Jun 20, 2025
jedcunningham
approved these changes
Jun 20, 2025
This was referenced Jul 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #50500
Adds a new safeguard for cases where the task subprocess closes
before all pipe sockets send EOF.
The supervisor now records the
process exit time and forcibly closes any sockets still open after
workers.socket_cleanup_timeout. This stops thesupervisor loop from hanging indefinitely and allows the process
to exit cleanly.
(cherry picked from commit a2651f1)
Co-authored-by: Kaxil Naik [email protected]