Skip to content

Remove db tests from fab provider #52171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

Remove db tests from fab provider #52171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion providers/fab/tests/unit/fab/auth_manager/api/auth/backend/test_basic_auth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ def function_decorated():
mock_call()


@pytest.mark.db_test
class TestBasicAuth:
def setup_method(self) -> None:
mock_call.reset_mock()
Expand Down
1 change: 0 additions & 1 deletion providers/fab/tests/unit/fab/auth_manager/api/auth/backend/test_session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ def function_decorated():
mock_call()


@pytest.mark.db_test
class TestSessionAuth:
def setup_method(self) -> None:
mock_call.reset_mock()
Expand Down
3 changes: 0 additions & 3 deletions providers/fab/tests/unit/fab/auth_manager/api_fastapi/routes/test_login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,9 @@

from unittest.mock import patch

import pytest

from airflow.providers.fab.auth_manager.api_fastapi.datamodels.login import LoginBody, LoginResponse


@pytest.mark.db_test
class TestLogin:
dummy_login_body = LoginBody(username="dummy", password="dummy")
dummy_token = LoginResponse(access_token="DUMMY_TOKEN")
Expand Down
1 change: 0 additions & 1 deletion providers/fab/tests/unit/fab/auth_manager/api_fastapi/services/test_login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
from airflow.providers.fab.auth_manager.api_fastapi.datamodels.login import LoginResponse


@pytest.mark.db_test
@patch("airflow.providers.fab.auth_manager.api_fastapi.services.login.get_auth_manager")
class TestLogin:
def setup_method(
Expand Down
2 changes: 0 additions & 2 deletions providers/fab/tests/unit/fab/auth_manager/cli_commands/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@
with ignore_provider_compatibility_error("2.9.0+", __file__):
from airflow.providers.fab.auth_manager.cli_commands.utils import get_application_builder

pytestmark = pytest.mark.db_test


@pytest.fixture
def flask_app():
Expand Down
5 changes: 0 additions & 5 deletions providers/fab/tests/unit/fab/auth_manager/test_fab_auth_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ def test_serialize_user(self, flask_app, auth_manager_with_appbuilder):
result = auth_manager_with_appbuilder.serialize_user(user)
assert result == {"sub": str(user.id)}

@pytest.mark.db_test
@mock.patch.object(FabAuthManager, "get_user")
def test_is_logged_in(self, mock_get_user, auth_manager_with_appbuilder):
user = Mock()
Expand All @@ -163,7 +162,6 @@ def test_is_logged_in(self, mock_get_user, auth_manager_with_appbuilder):

assert auth_manager_with_appbuilder.is_logged_in() is False

@pytest.mark.db_test
@mock.patch.object(FabAuthManager, "get_user")
def test_is_logged_in_with_inactive_user(self, mock_get_user, auth_manager_with_appbuilder):
user = Mock()
Expand Down Expand Up @@ -690,19 +688,16 @@ def test_get_authorized_dag_ids(

delete_user(flask_app, "username")

@pytest.mark.db_test
def test_security_manager_return_fab_security_manager_override(self, auth_manager_with_appbuilder):
assert isinstance(auth_manager_with_appbuilder.security_manager, FabAirflowSecurityManagerOverride)

@pytest.mark.db_test
def test_security_manager_return_custom_provided(self, flask_app, auth_manager_with_appbuilder):
class TestSecurityManager(FabAirflowSecurityManagerOverride):
pass

flask_app.config["SECURITY_MANAGER_CLASS"] = TestSecurityManager
assert isinstance(auth_manager_with_appbuilder.security_manager, TestSecurityManager)

@pytest.mark.db_test
def test_security_manager_wrong_inheritance_raise_exception(
self, flask_app, auth_manager_with_appbuilder
):
Expand Down
Loading