-
Notifications
You must be signed in to change notification settings - Fork 15.6k
docs: refresh Public Interface & align how-to guides for Airflow 3.0+ #52297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6a2ff20
to
f7daae6
Compare
Actually - I am not sure if we need to make a distinction vs. Airlfow 3 and Airflow 2 - as soon as we have a clearer way of showing that you are in Airflow 2 or Airflow 3, this should be likely more distinguishable. But what I would likely do here is just to focus on Airflow 3 public interface and have a BOLD LETTTERS at the top - somethign like This is Public interface for Airflow 3 - if you look for Airflow 2 public interface look -> Link to 2.11 version of the interface. |
Sorry - public interface of course not security model :) .. My mind was wandering a bit to another similar change we need to do. |
e95f771
to
e6fa6ae
Compare
@potiuk I have done the change as suggested above. |
f3dfd49
to
7cfa2bf
Compare
7cfa2bf
to
3f0877e
Compare
b1f7707
to
ca2b9b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are my last set of comments @sunank200.
Looking in pretty good shape!
451b4a2
to
6323a86
Compare
2fb6cde
to
d11695b
Compare
dd7ff71
to
2935862
Compare
…data direct access change
Co-Authored-By: Amogh Desai <[email protected]>
2935862
to
f80fbd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, we can come back at improvements at a later point again.
Please address the one comment I have prior to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if we can get it to 3.0.3 given the next RC? marked it for 3.0.4 for now
cc @kaxil
We have RC5 coming. We can get it in as it is doc-only. |
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker e8767b6 v3-0-test This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
…apache#52297) * docs: Update public interface documentation for Airflow 3.0+ for metadata direct access change * docs: replace direct metadata model imports in how-to examples with airflow.sdk * Make Public interface for Airflow 3 and add link for Airflow 2.11 * Fix PR comments * Update airflow-core/docs/public-airflow-interface.rst Co-Authored-By: Amogh Desai <[email protected]> * Fix PR comments * Remove duplicates and remove RuntimeTaskInstanceProtocol as it is not public * Fix PR comments --------- Co-authored-by: Amogh Desai <[email protected]> (cherry picked from commit e8767b6)
…apache#52297) * docs: Update public interface documentation for Airflow 3.0+ for metadata direct access change * docs: replace direct metadata model imports in how-to examples with airflow.sdk * Make Public interface for Airflow 3 and add link for Airflow 2.11 * Fix PR comments * Update airflow-core/docs/public-airflow-interface.rst Co-Authored-By: Amogh Desai <[email protected]> * Fix PR comments * Remove duplicates and remove RuntimeTaskInstanceProtocol as it is not public * Fix PR comments --------- Co-authored-by: Amogh Desai <[email protected]> (cherry picked from commit e8767b6)
…#52297) (#53011) * docs: Update public interface documentation for Airflow 3.0+ for metadata direct access change * docs: replace direct metadata model imports in how-to examples with airflow.sdk * Make Public interface for Airflow 3 and add link for Airflow 2.11 * Fix PR comments * Update airflow-core/docs/public-airflow-interface.rst * Fix PR comments * Remove duplicates and remove RuntimeTaskInstanceProtocol as it is not public * Fix PR comments --------- (cherry picked from commit e8767b6) Co-authored-by: Ankit Chaurasia <[email protected]> Co-authored-by: Amogh Desai <[email protected]>
…#52297) (#53011) * docs: Update public interface documentation for Airflow 3.0+ for metadata direct access change * docs: replace direct metadata model imports in how-to examples with airflow.sdk * Make Public interface for Airflow 3 and add link for Airflow 2.11 * Fix PR comments * Update airflow-core/docs/public-airflow-interface.rst * Fix PR comments * Remove duplicates and remove RuntimeTaskInstanceProtocol as it is not public * Fix PR comments --------- (cherry picked from commit e8767b6) Co-authored-by: Ankit Chaurasia <[email protected]> Co-authored-by: Amogh Desai <[email protected]>
…apache#52297) * docs: Update public interface documentation for Airflow 3.0+ for metadata direct access change * docs: replace direct metadata model imports in how-to examples with airflow.sdk * Make Public interface for Airflow 3 and add link for Airflow 2.11 * Fix PR comments * Update airflow-core/docs/public-airflow-interface.rst Co-Authored-By: Amogh Desai <[email protected]> * Fix PR comments * Remove duplicates and remove RuntimeTaskInstanceProtocol as it is not public * Fix PR comments --------- Co-authored-by: Amogh Desai <[email protected]>
…apache#52297) * docs: Update public interface documentation for Airflow 3.0+ for metadata direct access change * docs: replace direct metadata model imports in how-to examples with airflow.sdk * Make Public interface for Airflow 3 and add link for Airflow 2.11 * Fix PR comments * Update airflow-core/docs/public-airflow-interface.rst Co-Authored-By: Amogh Desai <[email protected]> * Fix PR comments * Remove duplicates and remove RuntimeTaskInstanceProtocol as it is not public * Fix PR comments --------- Co-authored-by: Amogh Desai <[email protected]>
This PR refreshed public-airflow-interface.rst for Airflow 3.0+, with the
airflow.sdk
, deprecating direct metadata DB access in task code, and pointing users to Task Context, REST API, or Python Client.This patch updates user how-to guides (connections, custom-operator, extra-link) to:
– Add warning against direct metadata-model imports
– Switch examples from
airflow.models.*
toairflow.sdk.*
classes and typescloses: #51590
closes: #52250
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.