Handle invalid execution API urls in supervisor #53082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoghrajesh
requested review from
ashb,
kaxil,
hussein-awala,
XD-DENG,
o-nikolas and
pierrejeambrun
as code owners
boring-cyborg
bot
added
area:Executors-core
amoghrajesh
added
the
backport-to-v3-0-test
kaxil
requested changes
Jul 9, 2025
kaxil
reviewed
Jul 9, 2025
amoghrajesh
force-pushed
the
handle-empty-baseurl
branch
from
1a3f7ca to
6f0d6ee
Compare
amoghrajesh
commented
Jul 10, 2025
amoghrajesh
changed the title
|
@kaxil what do you think of this approach? Makes more sense ig |
|
@kaxil could you take a look at this when you have some time? |
ashb
reviewed
Jul 14, 2025
ashb
reviewed
Jul 17, 2025
ashb
approved these changes
Jul 18, 2025
kaxil
approved these changes
Jul 18, 2025
|
This is a bugfix, can go in 3.0.4 |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 19, 2025
#53082) (cherry picked from commit e9e6ac2) Co-authored-by: Amogh Desai <[email protected]>
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jul 19, 2025
apache#53082) (cherry picked from commit e9e6ac2) Co-authored-by: Amogh Desai <[email protected]>
potiuk
pushed a commit
that referenced
this pull request
Jul 19, 2025
#53082) (#53518) (cherry picked from commit e9e6ac2) Co-authored-by: Amogh Desai <[email protected]>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #53033
Came across a case in the issue attached where the
base_urlwas set to empty and due to us not handling it well enough, it was getting through to later stages and resulting in execution API url being/executionwhich is not a good user experiences.The hidden issue is that conf.get returns an empty string "" instead of using the fallback value when empty string is set. This could be corrected over time, but is not needed as of now as it could have hidden effects and in most cases it is handled better further down.
Whatever the reason might be, the supervisor must account for this, and throw a better error message than just failing.
I am handling the case here by checking for valid URLs before creating the SDK client.
When its not provided.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.