[v3-0-test] Fix reading huge (XCom) resposne in TaskSDK task process (#53186) #53194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…53186) If you tried to send a large XCom value, it would fail in the task/child process side with this error: > RuntimeError: unable to read full response in child. (We read 36476, but expected 1310046) (The exact number that was able to read dependent on any different factors, like the OS, the current state of the socket and other things. Sometimes it would read up to 256kb fine, othertimes only 35kb as here) This is because the kernel level read-side socket buffer is full, so that was as much as the Supervisor could send. The fix is to read in a loop until we get it all. (cherry picked from commit b9620bf) Co-authored-by: Ash Berlin-Taylor <[email protected]>
ashb
approved these changes
Jul 11, 2025
kaxil
approved these changes
Jul 11, 2025
kaxil
pushed a commit
that referenced
this pull request
Jul 11, 2025
…53186) (#53194) If you tried to send a large XCom value, it would fail in the task/child process side with this error: > RuntimeError: unable to read full response in child. (We read 36476, but expected 1310046) (The exact number that was able to read dependent on any different factors, like the OS, the current state of the socket and other things. Sometimes it would read up to 256kb fine, othertimes only 35kb as here) This is because the kernel level read-side socket buffer is full, so that was as much as the Supervisor could send. The fix is to read in a loop until we get it all. (cherry picked from commit b9620bf) Co-authored-by: Ash Berlin-Taylor <[email protected]>
This was referenced Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you tried to send a large XCom value, it would fail in the task/child
process side with this error:
(The exact number that was able to read dependent on any different factors,
like the OS, the current state of the socket and other things. Sometimes it
would read up to 256kb fine, othertimes only 35kb as here)
This is because the kernel level read-side socket buffer is full, so that was
as much as the Supervisor could send. The fix is to read in a loop until we
get it all.
(cherry picked from commit b9620bf)
Co-authored-by: Ash Berlin-Taylor [email protected]