-
Notifications
You must be signed in to change notification settings - Fork 15.6k
Fix cherry-pick detection in airflow-github script #54287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+22
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix `is_cherrypicked` function to detect PRs with multiple reference numbers - Differentiate between Closed and Merged status for better PR state visibility - Add PEP 723 script dependencies for easier execution with 'uv run --no-project' The cherry-pick detection was failing for PRs that had additional PR numbers appended during cherry-picking (e.g., '(apache#53955) (apache#53964)'). This change improves release management workflow by providing clearer PR status information.
ashb
approved these changes
Aug 8, 2025
eladkal
approved these changes
Aug 8, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Aug 8, 2025
- Fix `is_cherrypicked` function to detect PRs with multiple reference numbers - Differentiate between Closed and Merged status for better PR state visibility - Add PEP 723 script dependencies for easier execution with 'uv run --no-project' The cherry-pick detection was failing for PRs that had additional PR numbers appended during cherry-picking (e.g., '(#53955) (#53964)'). This change improves release management workflow by providing clearer PR status information. (cherry picked from commit 29a1cb0) Co-authored-by: Kaxil Naik <[email protected]>
Nice! |
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 8, 2025
…e#54287) - Fix `is_cherrypicked` function to detect PRs with multiple reference numbers - Differentiate between Closed and Merged status for better PR state visibility - Add PEP 723 script dependencies for easier execution with 'uv run --no-project' The cherry-pick detection was failing for PRs that had additional PR numbers appended during cherry-picking (e.g., '(apache#53955) (apache#53964)'). This change improves release management workflow by providing clearer PR status information. (cherry picked from commit 29a1cb0) Co-authored-by: Kaxil Naik <[email protected]>
good update :) |
kaxil
added a commit
that referenced
this pull request
Aug 8, 2025
… (#54289) - Fix `is_cherrypicked` function to detect PRs with multiple reference numbers - Differentiate between Closed and Merged status for better PR state visibility - Add PEP 723 script dependencies for easier execution with 'uv run --no-project' The cherry-pick detection was failing for PRs that had additional PR numbers appended during cherry-picking (e.g., '(#53955) (#53964)'). This change improves release management workflow by providing clearer PR status information. (cherry picked from commit 29a1cb0) Co-authored-by: Kaxil Naik <[email protected]>
github-actions bot
pushed a commit
to astronomer/airflow
that referenced
this pull request
Aug 8, 2025
…e#54287) - Fix `is_cherrypicked` function to detect PRs with multiple reference numbers - Differentiate between Closed and Merged status for better PR state visibility - Add PEP 723 script dependencies for easier execution with 'uv run --no-project' The cherry-pick detection was failing for PRs that had additional PR numbers appended during cherry-picking (e.g., '(apache#53955) (apache#53964)'). This change improves release management workflow by providing clearer PR status information. (cherry picked from commit 29a1cb0) Co-authored-by: Kaxil Naik <[email protected]>
amoghrajesh
reviewed
Aug 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_cherrypicked
function to detect PRs with multiple reference numbersThe cherry-pick detection was failing for PRs that had additional PR numbers appended during cherry-picking (e.g., '(#53955) (#53964)'). This change improves release management workflow by providing clearer PR status information.
Previously it was showing the following even though it was cherry-picked:
Now:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.