-
Notifications
You must be signed in to change notification settings - Fork 15.6k
Switch to the triggered dagrun on manual trigger. #54336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! That really improves in my view.
Should we back-port this to 3.0.x?
I was first worried about that the run_id needs to be URL-encoded... only 99% sure after my testing... should work as it is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This is is SO MUCH BETTER :)
I would be for it. |
Current URL : http://localhost:8000/dags/example_display_name/runs/manual__2025-08-12T03:51:19.882418+00:00 Encoded URL : https://github.com/remix-run/react-router/blob/a089339c58ee0758db81b0a9c680b308628dddf7/packages/react-router/lib/hooks.tsx#L362 |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Ups, what went wrong here... was not the first PR for him... ?!?!? |
@jscheffl I am not sure. It didn't create the backport PR too. My guess is that there was a GitHub outage at the time the PR was merged that could have caused this. |
(cherry picked from commit 5c8c135)
Manual backport here: |
(cherry picked from commit 5c8c135) Co-authored-by: Karthikeyan Singaravelan <[email protected]>
(cherry picked from commit 5c8c135)
Whenever a dagrun is triggered manually from UI, switch to the triggered dagrun in graph/grid view similar to Airflow 2.
Closes #54189