[v3-0-test] Prevent repeated warning of triggers being added twice in triggerer (#54438) #54441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
… triggerer (#54438) When running multiple deferrable in parallel, triggers are repeatedly added to triggerer queue to create by the update_trigger's method. Then it's being skipped with a warning at the creating_trigger's method. The warning is too many when there're many tasks to defer causing inefficency. The fix here was to exclude the already queued triggers from the triggers to create and I purposely left the warning log of encountering a trigger already in to_create in case there's another way it could still be possible. (cherry picked from commit bfd0bbe) Co-authored-by: Ephraim Anierobi <[email protected]>
ephraimbuddy
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running multiple deferrable in parallel, triggers are repeatedly
added to triggerer queue to create by the update_trigger's method. Then it's
being skipped with a warning at the creating_trigger's method. The
warning is too many when there're many tasks to defer causing inefficency.
The fix here was to exclude the already queued triggers from the triggers to
create and I purposely left the warning log of encountering a trigger already
in to_create in case there's another way it could still be possible.
(cherry picked from commit bfd0bbe)
Co-authored-by: Ephraim Anierobi [email protected]