Skip to content

Conversation

github-actions[bot]
Copy link

  • fix(logging): fix module loading by using import_module()
  • Replace import_string() with import_module() in load_logging_config()
  • Fix issue where simple module paths like log_config.LOGGING_CONFIG failed
  • Add importlib import inside function to avoid circular imports
  • test(logging): add tests for logging config module path handling
  • Add parametrized test for simple and nested module paths
  • Add test for graceful fallback when remote logging vars are missing
  • Create helper method to reduce test code duplication
  • Test both log_config.LOGGING_CONFIG and nested.module.LOGGING_CONFIG scenarios

Ensures logging config works with various module path structures

  • fix(logging): fix module loading by using import_module()
  • Replace import_string() with import_module() in load_logging_config()
  • Fix issue where simple module paths like log_config.LOGGING_CONFIG failed
  • Add importlib import inside function to avoid circular imports
  • test(logging): add tests for logging config module path handling
  • Add parametrized test for simple and nested module paths
  • Add test for graceful fallback when remote logging vars are missing
  • Create helper method to reduce test code duplication
  • Test both log_config.LOGGING_CONFIG and nested.module.LOGGING_CONFIG scenarios

Ensures logging config works with various module path structures

  • fix(logging): fix module loading by using import_module()
  • Replace import_string() with import_module() in load_logging_config()
  • Fix issue where simple module paths like log_config.LOGGING_CONFIG failed
  • Add importlib import inside function to avoid circular imports
  • test(logging): add tests for logging config module path handling
  • Add parametrized test for simple and nested module paths
  • Add test for graceful fallback when remote logging vars are missing
  • Create helper method to reduce test code duplication
  • Test both log_config.LOGGING_CONFIG and nested.module.LOGGING_CONFIG scenarios

Ensures logging config works with various module path structures

  • refactor(logging): move import_module to the top level

  • test(logging): optimize test constants to reduce code duplication

Replace SETTINGS_FILE_NESTED_MODULE replicate part with string replacement from SETTINGS_FILE_SIMPLE_MODULE

  • test(logging): use shared helper method for logging config validation

Replace manual assertions with self._verify_basic_logging_config in fallback test to ensure consistent validation across all logging config tests.

  • refactor(logging_config): simplify, improve test config vars
  • Remove redundant SETTINGS_FILE_NESTED_MODULE
  • Rename SETTINGS_FILE_SIMPLE_MODULE to SETTINGS_FILE_WITH_REMOTE_VARS
  • refactor(logging): imporve & simplify logging testing file
  1. remove SETTING_FILE_NO_REMOTE_VARS bcz redundant var
  2. add return typo with _verify_basic_logging_config
  3. add unittest.mock call
    (cherry picked from commit 462ce9a)

Co-authored-by: Vic Wen [email protected]

* fix(logging): fix module loading by using `import_module()`

- Replace `import_string()` with `import_module()` in `load_logging_config()`
- Fix issue where simple module paths like `log_config.LOGGING_CONFIG` failed
- Add `importlib` import inside function to avoid circular imports

* test(logging): add tests for logging config module path handling

- Add parametrized test for simple and nested module paths
- Add test for graceful fallback when remote logging vars are missing
- Create helper method to reduce test code duplication
- Test both log_config.LOGGING_CONFIG and nested.module.LOGGING_CONFIG scenarios

Ensures logging config works with various module path structures

* fix(logging): fix module loading by using `import_module()`

- Replace `import_string()` with `import_module()` in `load_logging_config()`
- Fix issue where simple module paths like `log_config.LOGGING_CONFIG` failed
- Add `importlib` import inside function to avoid circular imports

* test(logging): add tests for logging config module path handling

- Add parametrized test for simple and nested module paths
- Add test for graceful fallback when remote logging vars are missing
- Create helper method to reduce test code duplication
- Test both log_config.LOGGING_CONFIG and nested.module.LOGGING_CONFIG scenarios

Ensures logging config works with various module path structures

* fix(logging): fix module loading by using `import_module()`

- Replace `import_string()` with `import_module()` in `load_logging_config()`
- Fix issue where simple module paths like `log_config.LOGGING_CONFIG` failed
- Add `importlib` import inside function to avoid circular imports

* test(logging): add tests for logging config module path handling

- Add parametrized test for simple and nested module paths
- Add test for graceful fallback when remote logging vars are missing
- Create helper method to reduce test code duplication
- Test both log_config.LOGGING_CONFIG and nested.module.LOGGING_CONFIG scenarios

Ensures logging config works with various module path structures

* refactor(logging): move `import_module` to the top level

* test(logging): optimize test constants to reduce code duplication

Replace `SETTINGS_FILE_NESTED_MODULE` replicate part with string replacement from `SETTINGS_FILE_SIMPLE_MODULE`

* test(logging): use shared helper method for logging config validation

Replace manual assertions with `self._verify_basic_logging_config` in fallback test to ensure consistent validation across all logging config tests.

* refactor(logging_config): simplify, improve test config vars

- Remove redundant `SETTINGS_FILE_NESTED_MODULE`
- Rename `SETTINGS_FILE_SIMPLE_MODULE` to `SETTINGS_FILE_WITH_REMOTE_VARS`

* refactor(logging): imporve & simplify logging testing file

1. remove `SETTING_FILE_NO_REMOTE_VARS` bcz redundant var
2. add return typo with `_verify_basic_logging_config`
3. add unittest.mock `call`
(cherry picked from commit 462ce9a)

Co-authored-by: Vic Wen <[email protected]>
@potiuk potiuk marked this pull request as ready for review August 19, 2025 23:43
@potiuk potiuk merged commit 560e85c into v3-0-test Aug 20, 2025
93 of 94 checks passed
@potiuk potiuk deleted the backport-462ce9a-v3-0-test branch August 20, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants