AIP-67 - Multi-team: CLI commands for multi team #55283
Open
+538
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLI commands for Create, List, Delete of teams. These are delivered as CLI commands instead of API because they are administrator only (similar to `airflow db reset`). These are not commands that DAG authors should be regularly running (therefore no APIs implemented)
vincbeck
reviewed
Sep 4, 2025
| @@ -305,6 +305,8 @@ def string_lower_type(val): | |||
| ARG_LOCAL = Arg(("-l", "--local"), help="Run the task using the LocalExecutor", action="store_true") | |||
| ARG_POOL = Arg(("--pool",), "Resource pool to use") | |||
|
|
|||
| # teams | |||
| ARG_TEAM_NAME = Arg(("name",), help="Team name") | |||
There was a problem hiding this comment.
What if you add required=True? Then you could remove _extract_team_name
There was a problem hiding this comment.
I think you will still need it because it is possible to pass things like empty string as the argument. But I still like making this required, so I'll make that change either way!
There was a problem hiding this comment.
Yeah, I just double checked and positional arguments are already required. But the input sanitation is still needed (for inputs like empty string).
vincbeck
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLI commands for Create, List, Delete of teams. These are delivered as CLI commands instead of API because they are administrator only (similar to
airflow db reset). These are not commands that DAG authors should be regularly running (therefore no APIs implemented)^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.