Skip to content

Conversation

dabla
Copy link
Contributor

@dabla dabla commented Sep 5, 2025

While working on AIP-88 I needed to patch the XComModel.set method but discovered my patches weren't taken into account. That's when I discovered that the set_xcom route in API server didn't delegate the logic to the XComModel set method but actually contains an almost identical copy of the set method, which is not DRY.

Maybe there is a reason for this? I created this PR which delegate the set of an xcom to the XComModel.set and catches the ValueError's thrown by the XComModel.set to return corresponding HTTPException's like it was originally implemented. Advantage of this is that the code isn't duplicated anymore and if a fix is done in XComModel.set method, the fix is also automatically applied in the API server. There will be probably other methods where this logic is duplicated, so maybe we have to do a more in-depth review for this unless there is a specific reason why the code is duplicate which I'm not aware off.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Sep 5, 2025
@dabla dabla requested a review from XD-DENG as a code owner September 5, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant