Make set_xcom route in API server DRY by reusing logic of XComModel.set method #55289
+17
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on AIP-88 I needed to patch the XComModel.set method but discovered my patches weren't taken into account. That's when I discovered that the set_xcom route in API server didn't delegate the logic to the XComModel set method but actually contains an almost identical copy of the set method, which is not DRY.
Maybe there is a reason for this? I created this PR which delegate the set of an xcom to the XComModel.set and catches the ValueError's thrown by the XComModel.set to return corresponding HTTPException's like it was originally implemented. Advantage of this is that the code isn't duplicated anymore and if a fix is done in XComModel.set method, the fix is also automatically applied in the API server. There will be probably other methods where this logic is duplicated, so maybe we have to do a more in-depth review for this unless there is a specific reason why the code is duplicate which I'm not aware off.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in airflow-core/newsfragments.