-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ConfigDrive: use file absolute path instead of canonical path to create ISO #11623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
Conversation
@blueorangutan package |
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11623 +/- ##
============================================
+ Coverage 16.17% 17.39% +1.22%
- Complexity 13297 15284 +1987
============================================
Files 5656 5888 +232
Lines 498136 526130 +27994
Branches 60432 64232 +3800
============================================
+ Hits 80583 91539 +10956
- Misses 408585 424257 +15672
- Partials 8968 10334 +1366
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14976 |
@blueorangutan test ol9 kvm-ol9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses issue #11622 by replacing usage of File.getCanonicalPath()
with File.getAbsolutePath()
in the ConfigDrive ISO creation functionality. This change aims to avoid potential issues with symbolic link resolution that can occur with canonical paths.
Key changes:
- Updated ConfigDriveBuilder to use absolute paths instead of canonical paths for ISO generation tools
- Updated corresponding unit tests to verify the new method calls
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
ConfigDriveBuilder.java | Modified getProgramToGenerateIso() method to use getAbsolutePath() instead of getCanonicalPath() |
ConfigDriveBuilderTest.java | Updated test verification calls to match the new getAbsolutePath() method usage |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
@blueorangutan test ol9 kvm-ol9 keepEnv |
@weizhouapache a [SL] Trillian-Jenkins test job (ol9 mgmt + kvm-ol9) has been kicked to run smoke tests |
[SF] Trillian test result (tid-14309)
|
[SF] Trillian test result (tid-14316)
|
@blueorangutan package |
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15001 |
@blueorangutan test |
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
@blueorangutan test ol9 kvm-ol9 |
@weizhouapache a [SL] Trillian-Jenkins test job (ol9 mgmt + kvm-ol9) has been kicked to run smoke tests |
Description
This PR fixes #11622
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?