Skip to content

Conversation

weizhouapache
Copy link
Member

Description

This PR fixes #11622

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache added this to the 4.20.2 milestone Sep 12, 2025
@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.39%. Comparing base (38006b2) to head (aa12b63).
⚠️ Report is 296 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11623      +/-   ##
============================================
+ Coverage     16.17%   17.39%   +1.22%     
- Complexity    13297    15284    +1987     
============================================
  Files          5656     5888     +232     
  Lines        498136   526130   +27994     
  Branches      60432    64232    +3800     
============================================
+ Hits          80583    91539   +10956     
- Misses       408585   424257   +15672     
- Partials       8968    10334    +1366     
Flag Coverage Δ
uitests 3.62% <ø> (-0.39%) ⬇️
unittests 18.44% <100.00%> (+1.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14976

@weizhouapache
Copy link
Member Author

@blueorangutan test ol9 kvm-ol9

@vishesh92 vishesh92 requested a review from Copilot September 12, 2025 09:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issue #11622 by replacing usage of File.getCanonicalPath() with File.getAbsolutePath() in the ConfigDrive ISO creation functionality. This change aims to avoid potential issues with symbolic link resolution that can occur with canonical paths.

Key changes:

  • Updated ConfigDriveBuilder to use absolute paths instead of canonical paths for ISO generation tools
  • Updated corresponding unit tests to verify the new method calls

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ConfigDriveBuilder.java Modified getProgramToGenerateIso() method to use getAbsolutePath() instead of getCanonicalPath()
ConfigDriveBuilderTest.java Updated test verification calls to match the new getAbsolutePath() method usage

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@weizhouapache
Copy link
Member Author

@blueorangutan test ol9 kvm-ol9 keepEnv

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol9 mgmt + kvm-ol9) has been kicked to run smoke tests

@weizhouapache weizhouapache marked this pull request as ready for review September 12, 2025 12:54
@blueorangutan
Copy link

[SF] Trillian test result (tid-14309)
Environment: kvm-ol9 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 63521 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11623-t14309-kvm-ol9.zip
Smoke tests completed. 145 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_deploy_and_scale_kubernetes_cluster Failure 1.17 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 27.84 test_kubernetes_clusters.py
test_01_redundant_vpc_site2site_vpn Failure 466.74 test_vpc_vpn.py
test_01_vpc_site2site_vpn Failure 296.60 test_vpc_vpn.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-14316)
Environment: kvm-ol9 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 59547 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11623-t14316-kvm-ol9.zip
Smoke tests completed. 146 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_deploy_and_scale_kubernetes_cluster Failure 1.17 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 29.88 test_kubernetes_clusters.py

@weizhouapache weizhouapache changed the base branch from main to 4.20 September 15, 2025 07:10
@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15001

@weizhouapache
Copy link
Member Author

@blueorangutan test

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@weizhouapache
Copy link
Member Author

@blueorangutan test ol9 kvm-ol9

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ol9 mgmt + kvm-ol9) has been kicked to run smoke tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ConfigDrive iso generation not working
3 participants