Skip to content

fix: When showMinLabel&showMaxLabel are set to true, the second item will be hidden(#20997) #21013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

fix: When showMinLabel&showMaxLabel are set to true, the second item will be hidden(#20997) #21013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d492797
fix: 20997
dexter-cuijian Jun 4, 2025
03997c0
fix: lint
dexter-cuijian Jun 4, 2025
0dffd57
test: add axis-showLabel.html
dexter-cuijian Jun 6, 2025
84a435d
test: change axis-showLabel.html
dexter-cuijian Jun 6, 2025
4eb18b5
fix: interval should work for all axis.type
dexter-cuijian Jun 13, 2025
02f8692
Merge branch 'apache:master' into fix-20997
dexter-cuijian Jun 13, 2025
97d1849
fix: hideOverlap is false, show all Labels
dexter-cuijian Jun 13, 2025
c43fa97
test(axisLabel): hideOverlap is false, show all Labels
dexter-cuijian Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/coord/axisHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,8 +368,10 @@ export function getOptionCategoryInterval(model: Model<AxisBaseOption['axisLabel
* @param {Object} axis axisModel.axis
*/
export function shouldShowAllLabels(axis: Axis): boolean {
return axis.type === 'category'
&& getOptionCategoryInterval(axis.getLabelModel()) === 0;
const labelModel = axis.getLabelModel();
const hideOverlap = labelModel.get('hideOverlap');
return hideOverlap === false
|| (axis.type === 'category' && getOptionCategoryInterval(labelModel) === 0);
}

export function getDataDimensionsOnAxis(data: SeriesData, axisDim: string): DimensionName[] {
Expand Down
113 changes: 113 additions & 0 deletions test/axis-hideOverlap.html
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading