Skip to content

fix: await get catalog in datafusion integration test and update version in python binding #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 1, 2025
Merged

fix: await get catalog in datafusion integration test and update version in python binding #1635

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0845fe9
Fix get catalog await
lliangyu-lin Aug 29, 2025
0a059a6
Attempt to fix the binding failure with setting underlying catalog safe
lliangyu-lin Aug 29, 2025
12aa489
Not sure about the issue, trying out fixes
lliangyu-lin Aug 29, 2025
c228eb6
Revert attempt to fix python binding issue
lliangyu-lin Aug 29, 2025
1e4eb00
pin arrow and datafusion version
lliangyu-lin Aug 30, 2025
709d17b
Update comment and retrigger flaky CI
lliangyu-lin Aug 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindings/python/tests/test_datafusion_table_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
import datafusion

assert (
datafusion.__version__ >= "45"
datafusion.__version__ >= "47"
) # iceberg table provider only works for datafusion >= 45
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the comments?



Expand Down
2 changes: 1 addition & 1 deletion crates/integrations/datafusion/src/table/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ pub struct IcebergTableProvider {
/// A reference-counted arrow `Schema`.
schema: ArrowSchemaRef,
/// The catalog that the table belongs to.
catalog: Option<Arc<dyn Catalog>>,
catalog: Option<Arc<dyn Catalog + Send + Sync + 'static>>,
}

impl IcebergTableProvider {
Expand Down
4 changes: 2 additions & 2 deletions crates/integrations/datafusion/tests/integration_datafusion_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,7 @@ async fn test_metadata_table() -> Result<()> {

#[tokio::test]
async fn test_insert_into() -> Result<()> {
let iceberg_catalog = get_iceberg_catalog();
let iceberg_catalog = get_iceberg_catalog().await;
let namespace = NamespaceIdent::new("test_insert_into".to_string());
set_test_namespace(&iceberg_catalog, &namespace).await?;

Expand Down Expand Up @@ -553,7 +553,7 @@ fn get_nested_struct_type() -> StructType {

#[tokio::test]
async fn test_insert_into_nested() -> Result<()> {
let iceberg_catalog = get_iceberg_catalog();
let iceberg_catalog = get_iceberg_catalog().await;
let namespace = NamespaceIdent::new("test_insert_nested".to_string());
set_test_namespace(&iceberg_catalog, &namespace).await?;
let table_name = "nested_table";
Expand Down
Loading