feat(writer): Add ClusteredWriter
#1646
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CTTY
commented
Sep 4, 2025
| self.data_file_builders.extend(inner.close().await?); | ||
|
|
||
| // Start a new writer | ||
| // TODO how to pass partition key to inner builder?? |
There was a problem hiding this comment.
Hi @liurenjie1024 ,
I think we've discussed a while ago that we don't really need a new PartitionWriter trait, as using the decorator pattern should be enough, but I'm having second thought here: it's tricky to configure PartitionKey for the inner_builder without changing the FileBuilder trait.. I feel like we need to change at least the FileWriterBuilder trait:
trait FileWriterBuilder {
...
fn with_partition_key();
}
Would love to hear your thoughts!
There was a problem hiding this comment.
The inner field doesn't have to be a trait, we can use RollingFileWriter directly. The RollingFileWriter returns DataFileBuilder, and in the way we can set the partition spec?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
Are these changes tested?
not yet