Use non-blocking transport for ConfigNodeRPCProcessor threads #16351
+26
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16351 +/- ##
============================================
- Coverage 38.80% 38.80% -0.01%
Complexity 198 198
============================================
Files 4912 4912
Lines 323413 323425 +12
Branches 41078 41085 +7
============================================
- Hits 125507 125506 -1
- Misses 197906 197919 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Seems uncorrelated for the code changes and the pr title/description |
Thx 4 ur kind concern. This PR is still W.I.P. Since we haven't found the best implementation according to the ConfigNodeRPCProcessor, I mark this PR to draft now. |
CRZbulabula
force-pushed
the
fix-cn-rpc-processor-block
branch
from
6a28e28 to
fd51420
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ConfigNodeRPCProcessor service would block for waiting to receive requests from DataNode, once when the connection is established. However, these threads would not be automatically recycled even there is no further requests. As a result, the number of threads in ConfigNode keep increase.
To recycle these idle threads in time, we use the non-blocking transport in this PR.