MINOR: Add 4.0.1 docs #719
Conversation
|
I had a quick check, because I was surprised to see the protocol_messages.html being included. As far as I can see the additions (I spot-checked some of them), have been present since December 2024 and are in the source code. As such, I think the current PR is correct, but I am happy to hear other opinions on the subject because I might be overlooking something simple |
clolov
force-pushed
the
asf-site-4-0-1-doc-update
branch
from
382011f to
82584e1
Compare
| @@ -30,7 +30,7 @@ | |||
| <!--#include virtual="toc.html" --> | |||
| </div> | |||
| <div class="right"> | |||
| <!--#include virtual="../includes/_docs_banner.htm" --> | |||
| <!--//#include virtual="../includes/_docs_banner.htm" --> | |||
There was a problem hiding this comment.
We don't want this change. We need to show the docs banner on 4.0 as 4.1 is now the latest docs.
| @@ -103,7 +103,7 @@ <h3>Primitive and basic types<a class="headerlink" href="#primitive-and-basic-ty | |||
| <pre class="line-numbers"><code class="language-xml"><dependency> | |||
| <groupId>org.apache.kafka</groupId> | |||
| <artifactId>kafka-clients</artifactId> | |||
| <version>{{fullDotVersion}}</version> | |||
| <version>2.8.0</version> | |||
There was a problem hiding this comment.
Why are we putting 2.8.0 here? I think we want {{fullDotVersion}} here
| @@ -224,7 +224,7 @@ <h3><a id="streams_api_changes_400" href="#streams_api_changes_400">Streams API | |||
|
|
|||
| <p> | |||
| In order to reduce storage overhead and improve API usability, a new method in the Java and Scala APIs that accepts a BiFunction for foreign key extraction is introduced by | |||
| <a href="https://cwiki.apache.org/confluence/x/gIuMEw">KIP-1104</a>. | |||
| <a href="">KIP-1104</a>. | |||
There was a problem hiding this comment.
I wasn't expected changes here but that looks correct. Not sure what happened with protocol_messages.html for 4.0 but it looks like it's currently wrong.
No description provided.