Skip to content

Commit 709c5fa

Browse files
authored
KAFKA-19666: Remove old restoration codepath from EosIntegrationTest [5/N] (#20499)
clean up `EosIntegrationTest.java` Reviewers: Lucas Brutschy <[email protected]>
1 parent a244565 commit 709c5fa

File tree

1 file changed

+1
-14
lines changed

1 file changed

+1
-14
lines changed

streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -788,19 +788,8 @@ public void shouldWriteLatestOffsetsToCheckpointOnShutdown(final boolean process
788788

789789
@ParameterizedTest
790790
@ValueSource(booleans = {true, false})
791-
public void shouldCheckpointRestoredOffsetsWhenClosingCleanDuringRestoringStateUpdaterEnabled(
791+
public void shouldCheckpointRestoredOffsetsWhenClosingCleanDuringRestoring(
792792
final boolean processingThreadsEnabled) throws Exception {
793-
shouldCheckpointRestoredOffsetsWhenClosingCleanDuringRestoring(processingThreadsEnabled, true);
794-
}
795-
796-
@Test
797-
public void shouldCheckpointRestoredOffsetsWhenClosingCleanDuringRestoringStateUpdaterDisabled() throws Exception {
798-
shouldCheckpointRestoredOffsetsWhenClosingCleanDuringRestoring(false, false);
799-
}
800-
801-
private void shouldCheckpointRestoredOffsetsWhenClosingCleanDuringRestoring(
802-
final boolean processingThreadsEnabled,
803-
final boolean stateUpdaterEnabled) throws Exception {
804793

805794
final Properties streamsConfiguration = new Properties();
806795
streamsConfiguration.put(StreamsConfig.APPLICATION_ID_CONFIG, applicationId);
@@ -812,7 +801,6 @@ private void shouldCheckpointRestoredOffsetsWhenClosingCleanDuringRestoring(
812801
streamsConfiguration.put(ConsumerConfig.AUTO_OFFSET_RESET_CONFIG, "earliest");
813802
streamsConfiguration.put(StreamsConfig.STATE_DIR_CONFIG, TestUtils.tempDirectory(applicationId).getPath());
814803
streamsConfiguration.put(InternalConfig.PROCESSING_THREADS_ENABLED, processingThreadsEnabled);
815-
streamsConfiguration.put(InternalConfig.STATE_UPDATER_ENABLED, stateUpdaterEnabled);
816804
streamsConfiguration.put(StreamsConfig.restoreConsumerPrefix(ConsumerConfig.MAX_POLL_RECORDS_CONFIG), 100);
817805
final String stateStoreName = "stateStore";
818806

@@ -1223,7 +1211,6 @@ public void process(final Record<Long, Long> record) {
12231211
properties.put(StreamsConfig.STATESTORE_CACHE_MAX_BYTES_CONFIG, 0);
12241212
properties.put(StreamsConfig.STATE_DIR_CONFIG, stateTmpDir + appDir);
12251213
properties.put(StreamsConfig.APPLICATION_SERVER_CONFIG, dummyHostName + ":2142");
1226-
properties.put(InternalConfig.STATE_UPDATER_ENABLED, processingThreadsEnabled);
12271214
properties.put(InternalConfig.PROCESSING_THREADS_ENABLED, processingThreadsEnabled);
12281215

12291216
final Properties config = StreamsTestUtils.getStreamsConfig(

0 commit comments

Comments
 (0)