Skip to content

Conversation

shashankhs11
Copy link
Contributor

@shashankhs11 shashankhs11 commented Sep 7, 2025

clean up EosIntegrationTest.java

Reviewers: Lucas Brutschy [email protected]

@github-actions github-actions bot added triage PRs from the community streams tests Test fixes (including flaky tests) small Small PRs labels Sep 7, 2025
@lucasbru lucasbru self-assigned this Sep 8, 2025
@lucasbru lucasbru requested a review from Copilot September 8, 2025 07:19
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up integration tests related to state-updater by removing redundant test methods and simplifying the test configuration. The changes eliminate duplicate test logic and remove the state-updater-specific configuration that is no longer needed.

  • Removes duplicate test methods for state-updater enabled/disabled scenarios
  • Simplifies test configuration by removing the STATE_UPDATER_ENABLED parameter
  • Consolidates test logic into parameterized tests that handle both processing thread configurations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@shashankhs11 shashankhs11 changed the title KAFKA-19666: Clean up integration tests related to state-updater KAFKA-19666: Remove old restoration codepath from EosIntegrationTest [5/N] Sep 8, 2025
@github-actions github-actions bot removed the triage PRs from the community label Sep 9, 2025
Copy link
Member

@lucasbru lucasbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lucasbru lucasbru merged commit 709c5fa into apache:trunk Sep 10, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-approved small Small PRs streams tests Test fixes (including flaky tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants