MINOR: Cleanup Server Module #20180
Merged
MINOR: Cleanup Server Module #20180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @chia7712 |
chia7712
reviewed
Jul 22, 2025
server/src/main/java/org/apache/kafka/server/share/session/ShareSessionKey.java
Outdated
Show resolved
Hide resolved
|
Gentle reminder @chia7712 |
|
Gentle reminder @chia7712 |
chia7712
reviewed
Aug 13, 2025
There was a problem hiding this comment.
@sjhajharia thanks for this patch. a couple of comments are left.
server/src/main/java/org/apache/kafka/server/config/ClientQuotaManagerConfig.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/quota/ClientSensors.java
Outdated
Show resolved
Hide resolved
| super(delayMs); | ||
| this.onAcksPending = onAcksPending; | ||
| this.deleteRecordsStatus = Collections.unmodifiableMap(deleteRecordsStatus); | ||
| this.deleteRecordsStatus = Map.copyOf(deleteRecordsStatus); |
There was a problem hiding this comment.
Is the deep copy necessary for now? or we could revisit this code after rewriting the ReplicaManager by java
There was a problem hiding this comment.
I agree with the later. Lets keep it as Map.copyOf and revisit the same once the Java conversion is complete.
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/apache/kafka/network/SocketServerConfigsTest.java
Outdated
Show resolved
Hide resolved
chia7712
reviewed
Aug 17, 2025
|
Gentle ping @chia7712 |
chia7712
reviewed
Aug 23, 2025
server/src/main/java/org/apache/kafka/server/share/session/ShareSessionKey.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/kafka/server/share/session/ShareSessionKey.java
Outdated
Show resolved
Hide resolved
|
Thanks @chia7712 for the review. |
|
Hey @chia7712 |
chia7712
approved these changes
Sep 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the PR title suggests, this PR is an attempt to perform some cleanups
in the server module. The changes are mostly around the use of Record
type for some classes, changes to use enhanced switch, etc.
Reviewers: Ken Huang [email protected], Chia-Ping Tsai
[email protected]